[x64] Do not compact constants with attached reloc info.

[x64] Do not compact constants with attached reloc info.

Reloc info often means that the constant will be patched later, and for
this patching we have to make sure that there is enough space in the
code for the new value.

R=bmeurer@chromium.org, titzer@chromium.org, gdeepti@chromium.org
BUG=chromium:684407
TEST=cctest/test-assembler-x64/Regression684407

Review-Url: https://codereview.chromium.org/2655213003
Cr-Commit-Position: refs/heads/master@{#42719}
Committed: https://chromium.googlesource.com/v8/v8/+/2a78f2980b3dc56cde5a10b1b554b38d2cc9f4c0

[ahaas, 2017-01-26 10:35:14]

The CQ bit was checked by ahaas@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-01-26 10:35:22]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[titzer, 2017-01-26 10:48:08]

The change looks fine, but let's put the test at the right level.

https://codereview.chromium.org/2655213003/diff/1/test/mjsunit/regress/wasm/r...
File test/mjsunit/regress/wasm/regression-684407.js (right):

https://codereview.chromium.org/2655213003/diff/1/test/mjsunit/regress/wasm/r...
test/mjsunit/regress/wasm/regression-684407.js:1: // Copyright 2017 the V8
project authors. All rights reserved.
Hmm, I don't think we should necessarily have a WASM-level test for this, but
instead an assembler-level test.

[commit-bot: I haz the power, 2017-01-26 11:08:56]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-01-26 11:08:57]

Dry run: This issue passed the CQ dry run.

[ahaas, 2017-01-26 15:24:26]

The CQ bit was checked by ahaas@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-01-26 15:24:34]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[ahaas, 2017-01-26 15:25:52]

Description was changed from

==========
[x64] Do not compact constants with attached reloc info.

Reloc info often means that the constant will be patched later, and for
this patching we have to make sure that there is enough space in the
code for the new value.

R=bmeurer@chromium.org, titzer@chromium.org, gdeepti@chromium.org
BUG=chromium:684407
TEST=mjsunit/regress/wasm/regression-684407
==========

to

==========
[x64] Do not compact constants with attached reloc info.

Reloc info often means that the constant will be patched later, and for
this patching we have to make sure that there is enough space in the
code for the new value.

R=bmeurer@chromium.org, titzer@chromium.org, gdeepti@chromium.org
BUG=chromium:684407
TEST=test-assembler-x64/Regression684407
==========

[ahaas, 2017-01-26 15:26:11]

Description was changed from

==========
[x64] Do not compact constants with attached reloc info.

Reloc info often means that the constant will be patched later, and for
this patching we have to make sure that there is enough space in the
code for the new value.

R=bmeurer@chromium.org, titzer@chromium.org, gdeepti@chromium.org
BUG=chromium:684407
TEST=test-assembler-x64/Regression684407
==========

to

==========
[x64] Do not compact constants with attached reloc info.

Reloc info often means that the constant will be patched later, and for
this patching we have to make sure that there is enough space in the
code for the new value.

R=bmeurer@chromium.org, titzer@chromium.org, gdeepti@chromium.org
BUG=chromium:684407
TEST=cctest/test-assembler-x64/Regression684407
==========

[ahaas, 2017-01-26 15:26:30]

On 2017/01/26 at 10:48:08, titzer wrote:
> The change looks fine, but let's put the test at the right level.
> 
>
https://codereview.chromium.org/2655213003/diff/1/test/mjsunit/regress/wasm/r...
> File test/mjsunit/regress/wasm/regression-684407.js (right):
> 
>
https://codereview.chromium.org/2655213003/diff/1/test/mjsunit/regress/wasm/r...
> test/mjsunit/regress/wasm/regression-684407.js:1: // Copyright 2017 the V8
project authors. All rights reserved.
> Hmm, I don't think we should necessarily have a WASM-level test for this, but
instead an assembler-level test.

Done.

[commit-bot: I haz the power, 2017-01-26 15:56:13]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-01-26 15:56:14]

Dry run: This issue passed the CQ dry run.

[titzer, 2017-01-26 21:08:16]

lgtm

[gdeepti, 2017-01-27 00:28:22]

The CQ bit was checked by gdeepti@chromium.org

[commit-bot: I haz the power, 2017-01-27 00:28:34]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-01-27 00:34:43]

CQ is committing da patch.

Bot data: {"patchset_id": 20001, "attempt_start_ts": 1485476902703590,
"parent_rev": "78c0be52d2d8e608a15b3a9a9192ad6a9ffaf6a7", "commit_rev":
"2a78f2980b3dc56cde5a10b1b554b38d2cc9f4c0"}

[commit-bot: I haz the power, 2017-01-27 00:34:47]

Description was changed from

==========
[x64] Do not compact constants with attached reloc info.

Reloc info often means that the constant will be patched later, and for
this patching we have to make sure that there is enough space in the
code for the new value.

R=bmeurer@chromium.org, titzer@chromium.org, gdeepti@chromium.org
BUG=chromium:684407
TEST=cctest/test-assembler-x64/Regression684407
==========

to

==========
[x64] Do not compact constants with attached reloc info.

Reloc info often means that the constant will be patched later, and for
this patching we have to make sure that there is enough space in the
code for the new value.

R=bmeurer@chromium.org, titzer@chromium.org, gdeepti@chromium.org
BUG=chromium:684407
TEST=cctest/test-assembler-x64/Regression684407

Review-Url: https://codereview.chromium.org/2655213003
Cr-Commit-Position: refs/heads/master@{#42719}
Committed:
https://chromium.googlesource.com/v8/v8/+/2a78f2980b3dc56cde5a10b1b554b38d2cc...
==========

[commit-bot: I haz the power, 2017-01-27 00:34:48]

Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/v8/v8/+/2a78f2980b3dc56cde5a10b1b554b38d2cc...