Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(294)

Issue 2655213002: mash: changes event dispatch to consider non-client area of all windows (Closed)

Created:
3 years, 11 months ago by sky
Modified:
3 years, 11 months ago
Reviewers:
Elliot Glaysher
CC:
chromium-reviews, rjkroege
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

mash: changes event dispatch to consider non-client area of all windows Previously if a window was marked as not accepting events then events would never target it. This means you could never drag a window as marked as not accepting events. This patch makes it so the non-client area can be targeted for these windows so that they can still be dragged and what not. BUG=685226 TEST=covered by test. R=erg@chromium.org Review-Url: https://codereview.chromium.org/2655213002 Cr-Commit-Position: refs/heads/master@{#446384} Committed: https://chromium.googlesource.com/chromium/src/+/9a265dc92c9aabf095817219ca44f094c81cfdd5

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+167 lines, -93 lines) Patch
M services/ui/ws/event_dispatcher.h View 2 chunks +2 lines, -1 line 0 comments Download
M services/ui/ws/event_dispatcher.cc View 4 chunks +27 lines, -46 lines 0 comments Download
M services/ui/ws/window_finder.h View 1 chunk +11 lines, -7 lines 0 comments Download
M services/ui/ws/window_finder.cc View 3 chunks +55 lines, -13 lines 0 comments Download
M services/ui/ws/window_finder_unittest.cc View 3 chunks +72 lines, -26 lines 0 comments Download

Messages

Total messages: 11 (7 generated)
sky
3 years, 11 months ago (2017-01-26 05:06:46 UTC) #1
Elliot Glaysher
lgtm
3 years, 11 months ago (2017-01-26 18:42:28 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2655213002/1
3 years, 11 months ago (2017-01-26 19:06:53 UTC) #8
commit-bot: I haz the power
3 years, 11 months ago (2017-01-26 19:22:04 UTC) #11
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/9a265dc92c9aabf095817219ca44...

Powered by Google App Engine
This is Rietveld 408576698