Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(48)

Issue 2655203002: Merge "Pass more hints to encoding detector." to M57 branch (Closed)

Created:
3 years, 11 months ago by tkent
Modified:
3 years, 11 months ago
Reviewers:
CC:
chromium-reviews
Target Ref:
refs/pending/branch-heads/2987
Project:
chromium
Visibility:
Public.

Description

Merge "Pass more hints to encoding detector." to M57 branch http://chart.fisco.co.jp/fisco/cgi-bin/index.cgi was incorrectly detected as GBK though it should be EUC-JP. Passing URL or user language "ja" fixes this issue. * Add |hintUrl| and |hintUserLanguage| arguments to detectTextEncoding(). * TextResourceDecoder passes defaultLanguage() to detectTextEncoding(). * TextResourceDecoderBuilder passes URL information to TextResourceDecoder, and TextResourceDecoder passes it to detectTextEncoding(). BUG=682978 Review-Url: https://codereview.chromium.org/2648703003 Cr-Commit-Position: refs/heads/master@{#445317} (cherry picked from commit 269b6bc66eb96f69d61d814ea7ec1ffef695eee3) Review-Url: https://codereview.chromium.org/2655203002 . Cr-Commit-Position: refs/branch-heads/2987@{#99} Cr-Branched-From: ad51088c0e8776e8dcd963dbe752c4035ba6dab6-refs/heads/master@{#444943} Committed: https://chromium.googlesource.com/chromium/src/+/0ad98a1fcf9a049d325c235fd07d317cf31bcf37

Patch Set 1 #

Messages

Total messages: 2 (1 generated)
tkent
3 years, 11 months ago (2017-01-26 04:39:36 UTC) #2
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
0ad98a1fcf9a049d325c235fd07d317cf31bcf37.

Powered by Google App Engine
This is Rietveld 408576698