Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(284)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 2655143002: Drop replacesCurrentHistoryItem, NavigationType (Closed)

Created:
3 years, 11 months ago by Nate Chapin
Modified:
3 years, 6 months ago
Reviewers:
CC:
chromium-reviews, nasko+codewatch_chromium.org, kinuko+watch, extensions-reviews_chromium.org, Yoav Weiss, blink-reviews-html_chromium.org, jam, dglazkov+blink, einbinder+watch-test-runner_chromium.org, gavinp+loader_chromium.org, loading-reviews_chromium.org, darin-cc_chromium.org, blink-reviews-api_chromium.org, mlamouri+watch-content_chromium.org, creis+watch_chromium.org, blink-reviews, chromium-apps-reviews_chromium.org, Nate Chapin, jochen+watch_chromium.org, tyoshino+watch_chromium.org, mlamouri+watch-test-runner_chromium.org, android-webview-reviews_chromium.org, jshin+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Drop replacesCurrentHistoryItem, NavigationType BUG=

Patch Set 1 #

Patch Set 2 : a #

Patch Set 3 : Fix android compile #

Patch Set 4 : More compile fixes #

Unified diffs Side-by-side diffs Delta from patch set Stats (+438 lines, -673 lines) Patch
M android_webview/renderer/aw_content_renderer_client.h View 1 chunk +1 line, -1 line 0 comments Download
M android_webview/renderer/aw_content_renderer_client.cc View 3 chunks +2 lines, -4 lines 0 comments Download
M chrome/renderer/loadtimes_extension_bindings.cc View 1 7 chunks +13 lines, -54 lines 0 comments Download
M components/test_runner/web_frame_test_client.h View 3 chunks +9 lines, -5 lines 0 comments Download
M components/test_runner/web_frame_test_client.cc View 1 7 chunks +14 lines, -38 lines 0 comments Download
M components/test_runner/web_frame_test_proxy.h View 4 chunks +22 lines, -18 lines 0 comments Download
M content/public/renderer/content_renderer_client.h View 1 2 chunks +1 line, -2 lines 0 comments Download
M content/public/renderer/content_renderer_client.cc View 1 1 chunk +1 line, -1 line 0 comments Download
M content/public/test/render_view_test.cc View 1 1 chunk +5 lines, -2 lines 0 comments Download
M content/renderer/render_frame_impl.h View 1 6 chunks +12 lines, -9 lines 0 comments Download
M content/renderer/render_frame_impl.cc View 1 2 33 chunks +71 lines, -90 lines 0 comments Download
M content/renderer/render_frame_impl_browsertest.cc View 1 2 3 6 chunks +16 lines, -8 lines 0 comments Download
M content/renderer/render_view_browsertest.cc View 1 2 3 9 chunks +20 lines, -17 lines 0 comments Download
M content/renderer/render_view_impl.h View 1 1 chunk +0 lines, -1 line 0 comments Download
M content/renderer/render_view_impl.cc View 1 1 chunk +0 lines, -1 line 0 comments Download
M third_party/WebKit/LayoutTests/fast/encoding/mailto-always-utf-8-expected.txt View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/LayoutTests/fast/forms/mailto/advanced-get-expected.txt View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/LayoutTests/fast/forms/mailto/advanced-put-expected.txt View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/LayoutTests/fast/forms/mailto/formenctype-attribute-button-html-expected.txt View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/LayoutTests/fast/forms/mailto/formenctype-attribute-input-2-expected.txt View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/LayoutTests/fast/forms/mailto/formenctype-attribute-input-html-expected.txt View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/LayoutTests/fast/forms/mailto/get-multiple-items-expected.txt View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/LayoutTests/fast/forms/mailto/get-multiple-items-text-plain-expected.txt View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/LayoutTests/fast/forms/mailto/get-multiple-items-x-www-form-urlencoded-expected.txt View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/LayoutTests/fast/forms/mailto/get-non-ascii-always-utf-8-expected.txt View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/LayoutTests/fast/forms/mailto/get-non-ascii-expected.txt View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/LayoutTests/fast/forms/mailto/get-non-ascii-text-plain-expected.txt View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/LayoutTests/fast/forms/mailto/get-non-ascii-text-plain-latin-1-expected.txt View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/LayoutTests/fast/forms/mailto/get-overwrite-query-expected.txt View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/LayoutTests/fast/forms/mailto/post-append-query-expected.txt View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/LayoutTests/fast/forms/mailto/post-multiple-items-expected.txt View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/LayoutTests/fast/forms/mailto/post-multiple-items-multipart-form-data-expected.txt View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/LayoutTests/fast/forms/mailto/post-multiple-items-text-plain-expected.txt View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/LayoutTests/fast/forms/mailto/post-multiple-items-x-www-form-urlencoded-expected.txt View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/LayoutTests/fast/forms/mailto/post-text-plain-expected.txt View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/LayoutTests/fast/forms/mailto/post-text-plain-with-accept-charset-expected.txt View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/LayoutTests/fast/loader/onload-policy-ignore-for-frame-expected.txt View 1 chunk +1 line, -1 line 0 comments Download
D third_party/WebKit/LayoutTests/fast/loader/reload-policy-delegate.html View 1 chunk +0 lines, -15 lines 0 comments Download
D third_party/WebKit/LayoutTests/fast/loader/reload-policy-delegate-expected.txt View 1 chunk +0 lines, -2 lines 0 comments Download
M third_party/WebKit/LayoutTests/http/tests/download/basic-ascii-expected.txt View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/LayoutTests/http/tests/download/default-encoding-expected.txt View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/LayoutTests/http/tests/download/inherited-encoding-expected.txt View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/LayoutTests/http/tests/download/inherited-encoding-form-submission-result-expected.txt View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/LayoutTests/http/tests/download/literal-utf-8-expected.txt View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/LayoutTests/http/tests/history/back-to-post-expected.txt View 1 chunk +3 lines, -3 lines 0 comments Download
M third_party/WebKit/LayoutTests/http/tests/misc/policy-delegate-called-twice-expected.txt View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/LayoutTests/http/tests/navigation/post-redirect-get-reload-expected.txt View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/LayoutTests/http/tests/security/feed-urls-from-remote-expected.txt View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/html/HTMLAnchorElement.cpp View 1 chunk +2 lines, -1 line 0 comments Download
M third_party/WebKit/Source/core/loader/DocumentLoader.h View 1 3 chunks +0 lines, -14 lines 0 comments Download
M third_party/WebKit/Source/core/loader/DocumentLoader.cpp View 1 2 chunks +2 lines, -4 lines 0 comments Download
M third_party/WebKit/Source/core/loader/EmptyClients.h View 1 4 chunks +8 lines, -6 lines 0 comments Download
M third_party/WebKit/Source/core/loader/EmptyClients.cpp View 1 chunk +1 line, -2 lines 0 comments Download
M third_party/WebKit/Source/core/loader/FrameFetchContext.cpp View 1 1 chunk +2 lines, -1 line 0 comments Download
M third_party/WebKit/Source/core/loader/FrameLoader.h View 1 2 chunks +1 line, -5 lines 0 comments Download
M third_party/WebKit/Source/core/loader/FrameLoader.cpp View 1 15 chunks +30 lines, -80 lines 0 comments Download
M third_party/WebKit/Source/core/loader/FrameLoaderClient.h View 1 4 chunks +18 lines, -15 lines 0 comments Download
M third_party/WebKit/Source/core/loader/FrameLoaderTypes.h View 1 chunk +0 lines, -9 lines 0 comments Download
M third_party/WebKit/Source/core/loader/PingLoaderTest.cpp View 1 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/timing/PerformanceBase.h View 1 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/timing/PerformanceBase.cpp View 1 2 chunks +10 lines, -8 lines 0 comments Download
M third_party/WebKit/Source/core/timing/PerformanceBaseTest.cpp View 1 2 chunks +5 lines, -5 lines 0 comments Download
M third_party/WebKit/Source/core/timing/PerformanceNavigation.cpp View 1 chunk +5 lines, -3 lines 0 comments Download
M third_party/WebKit/Source/web/FrameLoaderClientImpl.h View 1 3 chunks +13 lines, -9 lines 0 comments Download
M third_party/WebKit/Source/web/FrameLoaderClientImpl.cpp View 1 7 chunks +32 lines, -39 lines 0 comments Download
M third_party/WebKit/Source/web/WebDataSourceImpl.h View 2 chunks +0 lines, -4 lines 0 comments Download
M third_party/WebKit/Source/web/WebDataSourceImpl.cpp View 2 chunks +0 lines, -26 lines 0 comments Download
M third_party/WebKit/Source/web/WebEmbeddedWorkerImpl.h View 1 chunk +3 lines, -1 line 0 comments Download
M third_party/WebKit/Source/web/WebEmbeddedWorkerImpl.cpp View 1 1 chunk +2 lines, -1 line 0 comments Download
M third_party/WebKit/Source/web/WebLocalFrameImpl.cpp View 1 2 chunks +11 lines, -11 lines 0 comments Download
M third_party/WebKit/Source/web/WebPerformance.cpp View 1 chunk +0 lines, -15 lines 0 comments Download
M third_party/WebKit/Source/web/WebSharedWorkerImpl.h View 1 1 chunk +3 lines, -1 line 0 comments Download
M third_party/WebKit/Source/web/WebSharedWorkerImpl.cpp View 1 1 chunk +2 lines, -1 line 0 comments Download
M third_party/WebKit/Source/web/tests/LinkSelectionTest.cpp View 1 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/web/tests/WebDocumentSubresourceFilterTest.cpp View 1 chunk +3 lines, -3 lines 0 comments Download
M third_party/WebKit/Source/web/tests/WebFrameTest.cpp View 1 21 chunks +51 lines, -31 lines 0 comments Download
M third_party/WebKit/public/BUILD.gn View 1 1 chunk +0 lines, -1 line 0 comments Download
M third_party/WebKit/public/web/WebDataSource.h View 2 chunks +0 lines, -9 lines 0 comments Download
M third_party/WebKit/public/web/WebFrameClient.h View 1 8 chunks +11 lines, -12 lines 0 comments Download
D third_party/WebKit/public/web/WebNavigationType.h View 1 chunk +0 lines, -47 lines 0 comments Download
M third_party/WebKit/public/web/WebPerformance.h View 2 chunks +0 lines, -5 lines 0 comments Download

Depends on Patchset:

Issue 2653673006 Patch 60001

Messages

Total messages: 13 (13 generated)
Nate Chapin
The CQ bit was checked by japhet@chromium.org to run a CQ dry run
3 years, 11 months ago (2017-01-25 23:04:34 UTC) #1
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2655143002/1
3 years, 11 months ago (2017-01-25 23:05:33 UTC) #2
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
3 years, 11 months ago (2017-01-25 23:09:25 UTC) #3
commit-bot: I haz the power
Dry run: Try jobs failed on following builders: ios-device on master.tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-device/builds/142455) ios-device-xcode-clang on ...
3 years, 11 months ago (2017-01-25 23:09:26 UTC) #4
Nate Chapin
The CQ bit was checked by japhet@chromium.org to run a CQ dry run
3 years, 10 months ago (2017-01-27 23:05:33 UTC) #5
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2655143002/20001
3 years, 10 months ago (2017-01-27 23:06:32 UTC) #6
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
3 years, 10 months ago (2017-01-27 23:22:28 UTC) #7
commit-bot: I haz the power
Dry run: Try jobs failed on following builders: cast_shell_android on master.tryserver.chromium.android (JOB_FAILED, https://build.chromium.org/p/tryserver.chromium.android/builders/cast_shell_android/builds/201746) cast_shell_linux on ...
3 years, 10 months ago (2017-01-27 23:22:29 UTC) #8
Nate Chapin
The CQ bit was checked by japhet@chromium.org to run a CQ dry run
3 years, 10 months ago (2017-01-28 00:40:54 UTC) #9
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2655143002/60001
3 years, 10 months ago (2017-01-28 00:41:22 UTC) #10
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
3 years, 10 months ago (2017-01-28 00:47:00 UTC) #11
commit-bot: I haz the power
Dry run: Try jobs failed on following builders: linux_chromium_chromeos_rel_ng on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_chromeos_rel_ng/builds/355115)
3 years, 10 months ago (2017-01-28 00:47:01 UTC) #12
Nate Chapin
3 years, 6 months ago (2017-06-20 23:36:01 UTC) #13 
Description was changed from

==========
Drop replacesCurrentHistoryItem, NavigationType

BUG=
==========

to

==========
Drop replacesCurrentHistoryItem, NavigationType

BUG=
==========

Powered by Google App Engine
This is Rietveld 408576698