Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(879)

Unified Diff: third_party/WebKit/Source/core/timing/PerformanceBaseTest.cpp

Issue 2655143002: Drop replacesCurrentHistoryItem, NavigationType (Closed)
Patch Set: More compile fixes Created 3 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/core/timing/PerformanceBaseTest.cpp
diff --git a/third_party/WebKit/Source/core/timing/PerformanceBaseTest.cpp b/third_party/WebKit/Source/core/timing/PerformanceBaseTest.cpp
index 2cbe04647df76423697db029fa893b958c932f16..245cac49e7bc3a4fd71716d0373c257863047973 100644
--- a/third_party/WebKit/Source/core/timing/PerformanceBaseTest.cpp
+++ b/third_party/WebKit/Source/core/timing/PerformanceBaseTest.cpp
@@ -63,7 +63,7 @@ class PerformanceBaseTest : public ::testing::Test {
}
PerformanceNavigationTiming::NavigationType getNavigationType(
- NavigationType type,
+ FrameLoadType type,
Document* document) {
return PerformanceBase::getNavigationType(type, document);
}
@@ -148,19 +148,19 @@ TEST_F(PerformanceBaseTest, AddLongTaskTiming) {
TEST_F(PerformanceBaseTest, GetNavigationType) {
m_pageHolder->page().setVisibilityState(PageVisibilityStatePrerender, false);
PerformanceNavigationTiming::NavigationType returnedType =
- getNavigationType(NavigationTypeBackForward, &m_pageHolder->document());
+ getNavigationType(FrameLoadTypeBackForward, &m_pageHolder->document());
EXPECT_EQ(returnedType,
PerformanceNavigationTiming::NavigationType::Prerender);
m_pageHolder->page().setVisibilityState(PageVisibilityStateHidden, false);
returnedType =
- getNavigationType(NavigationTypeBackForward, &m_pageHolder->document());
+ getNavigationType(FrameLoadTypeBackForward, &m_pageHolder->document());
EXPECT_EQ(returnedType,
PerformanceNavigationTiming::NavigationType::BackForward);
m_pageHolder->page().setVisibilityState(PageVisibilityStateVisible, false);
- returnedType = getNavigationType(NavigationTypeFormResubmitted,
- &m_pageHolder->document());
+ returnedType =
+ getNavigationType(FrameLoadTypeStandard, &m_pageHolder->document());
EXPECT_EQ(returnedType,
PerformanceNavigationTiming::NavigationType::Navigate);
}

Powered by Google App Engine
This is Rietveld 408576698