Chromium Code Reviews
DescriptionRevert of Added DCHECK for monotonicTimeToDOMHighResTimeStamp in PerformanceBase (patchset #4 id:80001 of https://codereview.chromium.org/2622283007/ )
Reason for revert:
* in chrome on android, go to google.com
* click on sign in at top left
* start typing in the input box for user name (I was trying to type "webviewteam")
* crash
Fix: potentially get rid of the DCHECK and add an if statement to make sure the output time is never negative.
Original issue's description:
> Added DCHECK for monotonicTimeToDOMHighResTimeStamp in PerformanceBase. A few tests in FirstMeaningfulPaintDetectorTest break the DCHECK. Need to reset the initial value of their mock time function to be timeOrigin that was set in PerformanceBase.
>
> BUG=680623
> CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2
>
> Review-Url: https://codereview.chromium.org/2622283007
> Cr-Commit-Position: refs/heads/master@{#444134}
> Committed: https://chromium.googlesource.com/chromium/src/+/eeda089e4c29b7ed01c16c7e95987b28cf8c5620
TBR=panicker@chromium.org,ksakamoto@chromium.org,skobes@chromium.org
# Not skipping CQ checks because original CL landed more than 1 days ago.
BUG=680623
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2
Review-Url: https://codereview.chromium.org/2655123002
Cr-Commit-Position: refs/heads/master@{#446267}
Committed: https://chromium.googlesource.com/chromium/src/+/6468f57d306b277ce67c2ed44e5eff4caa8d7286
Patch Set 1 #Patch Set 2 : sync #
Messages
Total messages: 23 (11 generated)
|
|||||||||||||||||||||||||||||||||||||