Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(9)

Issue 2655123002: Revert of Added DCHECK for monotonicTimeToDOMHighResTimeStamp in PerformanceBase (Closed)

Created:
3 years, 11 months ago by sunjian
Modified:
3 years, 11 months ago
CC:
chromium-reviews, blink-reviews, dshwang, blink-reviews-paint_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of Added DCHECK for monotonicTimeToDOMHighResTimeStamp in PerformanceBase (patchset #4 id:80001 of https://codereview.chromium.org/2622283007/ ) Reason for revert: * in chrome on android, go to google.com * click on sign in at top left * start typing in the input box for user name (I was trying to type "webviewteam") * crash Fix: potentially get rid of the DCHECK and add an if statement to make sure the output time is never negative. Original issue's description: > Added DCHECK for monotonicTimeToDOMHighResTimeStamp in PerformanceBase. A few tests in FirstMeaningfulPaintDetectorTest break the DCHECK. Need to reset the initial value of their mock time function to be timeOrigin that was set in PerformanceBase. > > BUG=680623 > CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2 > > Review-Url: https://codereview.chromium.org/2622283007 > Cr-Commit-Position: refs/heads/master@{#444134} > Committed: https://chromium.googlesource.com/chromium/src/+/eeda089e4c29b7ed01c16c7e95987b28cf8c5620 TBR=panicker@chromium.org,ksakamoto@chromium.org,skobes@chromium.org # Not skipping CQ checks because original CL landed more than 1 days ago. BUG=680623 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2 Review-Url: https://codereview.chromium.org/2655123002 Cr-Commit-Position: refs/heads/master@{#446267} Committed: https://chromium.googlesource.com/chromium/src/+/6468f57d306b277ce67c2ed44e5eff4caa8d7286

Patch Set 1 #

Patch Set 2 : sync #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -16 lines) Patch
M third_party/WebKit/Source/core/paint/FirstMeaningfulPaintDetectorTest.cpp View 1 4 chunks +1 line, -12 lines 0 comments Download
M third_party/WebKit/Source/core/timing/PerformanceBase.h View 1 2 chunks +1 line, -3 lines 0 comments Download
M third_party/WebKit/Source/core/timing/PerformanceBase.cpp View 1 1 chunk +2 lines, -1 line 0 comments Download

Messages

Total messages: 23 (11 generated)
sunjian
Created Revert of Added DCHECK for monotonicTimeToDOMHighResTimeStamp in PerformanceBase
3 years, 11 months ago (2017-01-25 21:17:58 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2655123002/1
3 years, 11 months ago (2017-01-25 21:18:24 UTC) #3
commit-bot: I haz the power
No L-G-T-M from a valid reviewer yet. CQ run can only be started by full ...
3 years, 11 months ago (2017-01-25 21:18:26 UTC) #5
skobes
lgtm
3 years, 11 months ago (2017-01-25 21:19:09 UTC) #6
panicker
lgtm
3 years, 11 months ago (2017-01-25 21:19:45 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2655123002/1
3 years, 11 months ago (2017-01-25 21:20:32 UTC) #9
commit-bot: I haz the power
Try jobs failed on following builders: linux_android_rel_ng on master.tryserver.chromium.android (JOB_FAILED, https://build.chromium.org/p/tryserver.chromium.android/builders/linux_android_rel_ng/builds/220231)
3 years, 11 months ago (2017-01-26 00:00:44 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2655123002/100001
3 years, 11 months ago (2017-01-26 01:20:17 UTC) #15
commit-bot: I haz the power
Try jobs failed on following builders: win_chromium_rel_ng on master.tryserver.chromium.win (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_ng/builds/371254)
3 years, 11 months ago (2017-01-26 03:13:47 UTC) #17
Kunihiko Sakamoto
lgtm
3 years, 11 months ago (2017-01-26 05:44:38 UTC) #19
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2655123002/100001
3 years, 11 months ago (2017-01-26 05:45:03 UTC) #20
commit-bot: I haz the power
3 years, 11 months ago (2017-01-26 07:25:37 UTC) #23
Message was sent while issue was closed.
Committed patchset #2 (id:100001) as
https://chromium.googlesource.com/chromium/src/+/6468f57d306b277ce67c2ed44e5e...

Powered by Google App Engine
This is Rietveld 408576698