[gpu/GLES2DecoderImpl] Force updating scissor state on Nexus 7 gen.2

[gpu/GLES2DecoderImpl] Force updating scissor state on Nexus 7 gen.2

Nexus 7 gen.2 shipped with some buggy GPU driver that can have stale
scissor state after switching current framebuffer to FBO0.

The theory is that FBO0 keeps some internal (in HW regs maybe?) scissor test
state, but the driver forgets to update it with GL_SCISSOR_TEST when FBO0 gets
bound. (So it stuck with whatever state we last switched from it.)

Also the state could stuck even if we explicitly set GL_SCISSOR_TEST again
after switching to FBO0, because the driver early exits if the new
GL_SCISSOR_TEST value matches the old one.

This CL add a workaround in GLES2DecoderImpl to shake up the scissor state
whenever we just switched to FBO0.

BUG=670607
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel

Review-Url: https://codereview.chromium.org/2655073008
Cr-Commit-Position: refs/heads/master@{#446894}
Committed: https://chromium.googlesource.com/chromium/src/+/1870af92713b4c2eefd45312b7cf9c5c18477f59

[trchen, 2017-01-27 07:37:42]

Description was changed from

==========
[gpu/GLES2DecoderImpl] Force updating scissor state on Nexus 7 gen.2

Nexus 7 gen.2 shipped with some buggy GPU driver that can have stale
scissor state after switching current framebuffer to FBO0.

The theory is that FBO0 keeps some internal (in HW regs maybe?) scissor test
state, but the driver forgets to update it with GL_SCISSOR_TEST when FBO0 gets
bound. (So it stuck with whatever state we last switched from it.)

Also the state could stuck even if we explicitly set GL_SCISSOR_TEST again
after switching to FBO0, because the driver early exits if the new
GL_SCISSOR_TEST value matches the old one.

This CL add a workaround in GLES2DecoderImpl to shake up the scissor state
whenever we just switched to FBO0.

BUG=670607
==========

to

==========
[gpu/GLES2DecoderImpl] Force updating scissor state on Nexus 7 gen.2

Nexus 7 gen.2 shipped with some buggy GPU driver that can have stale
scissor state after switching current framebuffer to FBO0.

The theory is that FBO0 keeps some internal (in HW regs maybe?) scissor test
state, but the driver forgets to update it with GL_SCISSOR_TEST when FBO0 gets
bound. (So it stuck with whatever state we last switched from it.)

Also the state could stuck even if we explicitly set GL_SCISSOR_TEST again
after switching to FBO0, because the driver early exits if the new
GL_SCISSOR_TEST value matches the old one.

This CL add a workaround in GLES2DecoderImpl to shake up the scissor state
whenever we just switched to FBO0.

BUG=670607
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
==========

[trchen, 2017-01-27 07:39:24]

trchen@chromium.org changed reviewers:
+ brianderson@chromium.org, zmo@chromium.org

[trchen, 2017-01-27 07:39:29]

The CQ bit was checked by trchen@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-01-27 07:39:43]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[brianderson, 2017-01-27 08:07:57]

Nice! Only have one nit.

https://codereview.chromium.org/2655073008/diff/1/gpu/command_buffer/service/...
File gpu/command_buffer/service/gles2_cmd_decoder.cc (right):

https://codereview.chromium.org/2655073008/diff/1/gpu/command_buffer/service/...
gpu/command_buffer/service/gles2_cmd_decoder.cc:5638:
!GetBoundDrawFramebufferServiceId()) {
...Id() == 0

[commit-bot: I haz the power, 2017-01-27 08:29:18]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-01-27 08:29:19]

Dry run: This issue passed the CQ dry run.

[Zhenyao Mo, 2017-01-27 18:39:52]

On 2017/01/27 08:07:57, brianderson wrote:
> Nice! Only have one nit.
> 
>
https://codereview.chromium.org/2655073008/diff/1/gpu/command_buffer/service/...
> File gpu/command_buffer/service/gles2_cmd_decoder.cc (right):
> 
>
https://codereview.chromium.org/2655073008/diff/1/gpu/command_buffer/service/...
> gpu/command_buffer/service/gles2_cmd_decoder.cc:5638:
> !GetBoundDrawFramebufferServiceId()) {
> ...Id() == 0

lgtm when brianderson's nit addressed

[trchen, 2017-01-27 21:41:50]

The CQ bit was checked by trchen@chromium.org

[trchen, 2017-01-27 21:41:50]

The patchset sent to the CQ was uploaded after l-g-t-m from zmo@chromium.org
Link to the patchset: https://codereview.chromium.org/2655073008/#ps20001
(title: "fix nits")

[commit-bot: I haz the power, 2017-01-27 21:42:25]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-01-27 23:18:26]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-01-27 23:18:27]

Try jobs failed on following builders:
  linux_android_rel_ng on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/linux_androi...)

[trchen, 2017-01-28 02:20:30]

The CQ bit was checked by trchen@chromium.org

[commit-bot: I haz the power, 2017-01-28 02:20:58]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-01-28 03:12:26]

CQ is committing da patch.

Bot data: {"patchset_id": 20001, "attempt_start_ts": 1485570030828420,
"parent_rev": "a23910d9e9bf955bbf1f0623628dee181135a957", "commit_rev":
"1870af92713b4c2eefd45312b7cf9c5c18477f59"}

[commit-bot: I haz the power, 2017-01-28 03:12:54]

Description was changed from

==========
[gpu/GLES2DecoderImpl] Force updating scissor state on Nexus 7 gen.2

Nexus 7 gen.2 shipped with some buggy GPU driver that can have stale
scissor state after switching current framebuffer to FBO0.

The theory is that FBO0 keeps some internal (in HW regs maybe?) scissor test
state, but the driver forgets to update it with GL_SCISSOR_TEST when FBO0 gets
bound. (So it stuck with whatever state we last switched from it.)

Also the state could stuck even if we explicitly set GL_SCISSOR_TEST again
after switching to FBO0, because the driver early exits if the new
GL_SCISSOR_TEST value matches the old one.

This CL add a workaround in GLES2DecoderImpl to shake up the scissor state
whenever we just switched to FBO0.

BUG=670607
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
==========

to

==========
[gpu/GLES2DecoderImpl] Force updating scissor state on Nexus 7 gen.2

Nexus 7 gen.2 shipped with some buggy GPU driver that can have stale
scissor state after switching current framebuffer to FBO0.

The theory is that FBO0 keeps some internal (in HW regs maybe?) scissor test
state, but the driver forgets to update it with GL_SCISSOR_TEST when FBO0 gets
bound. (So it stuck with whatever state we last switched from it.)

Also the state could stuck even if we explicitly set GL_SCISSOR_TEST again
after switching to FBO0, because the driver early exits if the new
GL_SCISSOR_TEST value matches the old one.

This CL add a workaround in GLES2DecoderImpl to shake up the scissor state
whenever we just switched to FBO0.

BUG=670607
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel

Review-Url: https://codereview.chromium.org/2655073008
Cr-Commit-Position: refs/heads/master@{#446894}
Committed:
https://chromium.googlesource.com/chromium/src/+/1870af92713b4c2eefd45312b7cf...
==========

[commit-bot: I haz the power, 2017-01-28 03:12:55]

Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/1870af92713b4c2eefd45312b7cf...