Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(45)

Issue 2655073007: Revert of [Presentation API] Allow PresentationConnection state change to "Connecting" (Closed)

Created:
3 years, 11 months ago by suzyh_UTC10 (ex-contributor)
Modified:
3 years, 11 months ago
CC:
blink-reviews, chromium-reviews, haraken, zhaobin
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of [Presentation API] Allow PresentationConnection state change to "Connecting" (patchset #5 id:180001 of https://codereview.chromium.org/2643473002/ ) Reason for revert: presentation/presentation-close-reconnect.html is timing out consistently on e.g. WebKit Linux Trusty https://build.chromium.org/p/chromium.webkit/builders/WebKit%20Linux%20Trusty/builds/22580 Original issue's description: > [Presentation API] Allow PresentationConnection state change to "Connecting" > > As per the Presentation API spec [1], when we reconnect to a closed > PresentationConnection, its status changes from Closed to Connecting. This CL > removes a NOTREACHED() called at state change to Connecting. > > This CL also replaces the use of the var keyword with const/let in > third_party/WebKit/LayoutTests/presentation/. > > [1] https://w3c.github.io/presentation-api/#reconnecting-to-a-presentation > > BUG=677540 > > Review-Url: https://codereview.chromium.org/2643473002 > Cr-Commit-Position: refs/heads/master@{#446458} > Committed: https://chromium.googlesource.com/chromium/src/+/a8f908ca6ab0abe86af75c688099d8c9dee1685c TBR=mfoltz@chromium.org,zhaobin@chromium.org,takumif@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=677540 Review-Url: https://codereview.chromium.org/2655073007 Cr-Commit-Position: refs/heads/master@{#446578} Committed: https://chromium.googlesource.com/chromium/src/+/fb6e9d1fd67d2ee811d5276e6d07940cb2faf342

Patch Set 1 #

Messages

Total messages: 6 (3 generated)
suzyh_UTC10 (ex-contributor)
Created Revert of [Presentation API] Allow PresentationConnection state change to "Connecting"
3 years, 11 months ago (2017-01-27 03:40:00 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2655073007/1
3 years, 11 months ago (2017-01-27 03:40:24 UTC) #3
commit-bot: I haz the power
3 years, 11 months ago (2017-01-27 03:41:51 UTC) #6
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/fb6e9d1fd67d2ee811d5276e6d07...

Powered by Google App Engine
This is Rietveld 408576698