Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(739)

Issue 2655063003: [Test] Add micro-benchmarks for super-calls with spread. (Closed)

Created:
3 years, 11 months ago by petermarshall
Modified:
3 years, 11 months ago
Reviewers:
Benedikt Meurer
CC:
v8-reviews_googlegroups.com, Franzi
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[Test] Add micro-benchmarks for super-calls with spread. We compare ES5, ES6 and a Babel transpilation of the ES6 test. BUG=v8:5894 Review-Url: https://codereview.chromium.org/2655063003 Cr-Commit-Position: refs/heads/master@{#42689} Committed: https://chromium.googlesource.com/v8/v8/+/2db0e8cbcf93bdcbf77d7a7a1e7d461e8d6fce5f

Patch Set 1 #

Patch Set 2 : Add future flag #

Unified diffs Side-by-side diffs Delta from patch set Stats (+172 lines, -1 line) Patch
M test/js-perf-test/SixSpeed.json View 1 2 chunks +17 lines, -1 line 0 comments Download
A test/js-perf-test/SixSpeed/super_spread/run.js View 1 chunk +22 lines, -0 lines 0 comments Download
A test/js-perf-test/SixSpeed/super_spread/super_spread.js View 1 chunk +133 lines, -0 lines 0 comments Download

Messages

Total messages: 14 (10 generated)
petermarshall
PTAL =]
3 years, 11 months ago (2017-01-26 10:23:05 UTC) #4
Benedikt Meurer
LGTM!
3 years, 11 months ago (2017-01-26 11:28:04 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2655063003/20001
3 years, 11 months ago (2017-01-26 11:29:26 UTC) #11
commit-bot: I haz the power
3 years, 11 months ago (2017-01-26 11:31:15 UTC) #14
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/v8/v8/+/2db0e8cbcf93bdcbf77d7a7a1e7d461e8d6...

Powered by Google App Engine
This is Rietveld 408576698