telemetry_unittests: set number of shards to be 4 on linux & 2 on other desktop bots

telemetry_unittests: set number of shards to be 4 on linux & 2 on other desktop bots

BUG=676742
Review-Url: https://codereview.chromium.org/2655063002
Cr-Commit-Position: refs/heads/master@{#446177}
Committed: https://chromium.googlesource.com/chromium/src/+/e3737854d8bf3f7d81ae7e5d852b0c914541935f

[nednguyen, 2017-01-25 17:50:36]

Patchset #1 (id:1) has been deleted

[nednguyen, 2017-01-25 17:50:55]

Description was changed from

==========
Set number of shards to be 5 for telemetry_unittests suite on desktop bots

BUG=676742
==========

to

==========
Set number of shards to be 4 for telemetry_unittests suite on desktop bots

BUG=676742
==========

[nednguyen, 2017-01-25 17:50:55]

nednguyen@google.com changed reviewers:
+ dpranke@chromium.org, jam@chromium.org

[nednguyen, 2017-01-25 17:51:06]

The CQ bit was checked by nednguyen@google.com to run a CQ dry run

[commit-bot: I haz the power, 2017-01-25 17:51:30]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[jam, 2017-01-25 18:43:58]

Same question as
https://bugs.chromium.org/p/chromium/issues/detail?id=676742#c26, if on
mac/windows we have multiple instances running on one machine, do we need 4
shards?

Also are you sure that it'll always pass in under 5 minutes? We don't want it
sometimes running over and failing CQ runs because of that. Should you perhaps
remove the hard limit part and monitor runtime to see if it needs to be sharded
differently instead?

[nednguyen, 2017-01-25 19:25:31]

The CQ bit was checked by nednguyen@google.com to run a CQ dry run

[commit-bot: I haz the power, 2017-01-25 19:26:21]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Dirk Pranke, 2017-01-25 19:45:29]

lgtm

[nednguyen, 2017-01-25 20:35:41]

On 2017/01/25 18:43:58, jam wrote:
> Same question as
> https://bugs.chromium.org/p/chromium/issues/detail?id=676742#c26, if on
> mac/windows we have multiple instances running on one machine, do we need 4
> shards?
> 
> Also are you sure that it'll always pass in under 5 minutes? We don't want it
> sometimes running over and failing CQ runs because of that. Should you perhaps
> remove the hard limit part and monitor runtime to see if it needs to be
sharded
> differently instead?

It takes:
10m 36s on Mac:
https://chromium-swarm.appspot.com/task?id=33f01480eb4acc10&refresh=10&show_r...
(0 flaky tests)

9m29s on Windows:
https://chromium-swarm.appspot.com/task?id=33f01305d8364a10&refresh=10&show_r...
(0 flaky tests)

So I can set shards = 2 for Mac & Win, wdyt?

[Dirk Pranke, 2017-01-25 21:38:32]

On 2017/01/25 20:35:41, nednguyen wrote:
> On 2017/01/25 18:43:58, jam wrote:
> > Same question as
> > https://bugs.chromium.org/p/chromium/issues/detail?id=676742#c26, if on
> > mac/windows we have multiple instances running on one machine, do we need 4
> > shards?
> > 
> > Also are you sure that it'll always pass in under 5 minutes? We don't want
it
> > sometimes running over and failing CQ runs because of that. Should you
perhaps
> > remove the hard limit part and monitor runtime to see if it needs to be
> sharded
> > differently instead?
> 
> It takes:
> 10m 36s on Mac:
>
https://chromium-swarm.appspot.com/task?id=33f01480eb4acc10&refresh=10&show_r...
> (0 flaky tests)
> 
> 9m29s on Windows:
>
https://chromium-swarm.appspot.com/task?id=33f01305d8364a10&refresh=10&show_r...
> (0 flaky tests)
> 
> So I can set shards = 2 for Mac & Win, wdyt?

I'd be fine w/ any number between 2 and 4. I'm not sure I see a strong reason
not to use 4, as long as we have the resources.

[commit-bot: I haz the power, 2017-01-25 23:42:21]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-01-25 23:42:22]

Dry run: This issue passed the CQ dry run.

[jam, 2017-01-25 23:56:17]

On 2017/01/25 21:38:32, Dirk Pranke wrote:
> On 2017/01/25 20:35:41, nednguyen wrote:
> > On 2017/01/25 18:43:58, jam wrote:
> > > Same question as
> > > https://bugs.chromium.org/p/chromium/issues/detail?id=676742#c26, if on
> > > mac/windows we have multiple instances running on one machine, do we need
4
> > > shards?
> > > 
> > > Also are you sure that it'll always pass in under 5 minutes? We don't want
> it
> > > sometimes running over and failing CQ runs because of that. Should you
> perhaps
> > > remove the hard limit part and monitor runtime to see if it needs to be
> > sharded
> > > differently instead?
> > 
> > It takes:
> > 10m 36s on Mac:
> >
>
https://chromium-swarm.appspot.com/task?id=33f01480eb4acc10&refresh=10&show_r...
> > (0 flaky tests)
> > 
> > 9m29s on Windows:
> >
>
https://chromium-swarm.appspot.com/task?id=33f01305d8364a10&refresh=10&show_r...
> > (0 flaky tests)
> > 
> > So I can set shards = 2 for Mac & Win, wdyt?
> 
> I'd be fine w/ any number between 2 and 4. I'm not sure I see a strong reason
> not to use 4, as long as we have the resources.

lgtm with adding 2 for others. i think it's preferable to use 2 instead of 4 as
there is overhead per shard, and not worth it if it'll run in 2-3 minutes. also
not using hard timesouts

[nednguyen, 2017-01-26 00:33:14]

Description was changed from

==========
Set number of shards to be 4 for telemetry_unittests suite on desktop bots

BUG=676742
==========

to

==========
telemetry_unittests: set number of shards to be 4 on linux & 2 on other desktop
bots

BUG=676742
==========

[nednguyen, 2017-01-26 00:33:19]

The CQ bit was checked by nednguyen@google.com

[commit-bot: I haz the power, 2017-01-26 00:34:14]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-01-26 00:52:31]

CQ is committing da patch.

Bot data: {"patchset_id": 40001, "attempt_start_ts": 1485390799087120,
"parent_rev": "a089b8668e5e617a4181a6f9532672049339134b", "commit_rev":
"e3737854d8bf3f7d81ae7e5d852b0c914541935f"}

[commit-bot: I haz the power, 2017-01-26 00:52:59]

Description was changed from

==========
telemetry_unittests: set number of shards to be 4 on linux & 2 on other desktop
bots

BUG=676742
==========

to

==========
telemetry_unittests: set number of shards to be 4 on linux & 2 on other desktop
bots

BUG=676742

Review-Url: https://codereview.chromium.org/2655063002
Cr-Commit-Position: refs/heads/master@{#446177}
Committed:
https://chromium.googlesource.com/chromium/src/+/e3737854d8bf3f7d81ae7e5d852b...
==========

[commit-bot: I haz the power, 2017-01-26 00:53:06]

Committed patchset #2 (id:40001) as
https://chromium.googlesource.com/chromium/src/+/e3737854d8bf3f7d81ae7e5d852b...

[jam1, 2017-01-26 02:32:10]

On 2017/01/25 23:56:17, jam wrote:
> On 2017/01/25 21:38:32, Dirk Pranke wrote:
> > On 2017/01/25 20:35:41, nednguyen wrote:
> > > On 2017/01/25 18:43:58, jam wrote:
> > > > Same question as
> > > > https://bugs.chromium.org/p/chromium/issues/detail?id=676742#c26, if on
> > > > mac/windows we have multiple instances running on one machine, do we
need
> 4
> > > > shards?
> > > > 
> > > > Also are you sure that it'll always pass in under 5 minutes? We don't
want
> > it
> > > > sometimes running over and failing CQ runs because of that. Should you
> > perhaps
> > > > remove the hard limit part and monitor runtime to see if it needs to be
> > > sharded
> > > > differently instead?
> > > 
> > > It takes:
> > > 10m 36s on Mac:
> > >
> >
>
https://chromium-swarm.appspot.com/task?id=33f01480eb4acc10&refresh=10&show_r...
> > > (0 flaky tests)
> > > 
> > > 9m29s on Windows:
> > >
> >
>
https://chromium-swarm.appspot.com/task?id=33f01305d8364a10&refresh=10&show_r...
> > > (0 flaky tests)
> > > 
> > > So I can set shards = 2 for Mac & Win, wdyt?
> > 
> > I'd be fine w/ any number between 2 and 4. I'm not sure I see a strong
reason
> > not to use 4, as long as we have the resources.
> 
> lgtm with adding 2 for others. i think it's preferable to use 2 instead of 4
as
> there is overhead per shard, and not worth it if it'll run in 2-3 minutes.
also
> not using hard timesouts

What about adding 2 for mac/windows so they dont take 10 minutes?

[nednguyen, 2017-01-26 11:40:18]

On 2017/01/26 02:32:10, jam1 wrote:
> On 2017/01/25 23:56:17, jam wrote:
> > On 2017/01/25 21:38:32, Dirk Pranke wrote:
> > > On 2017/01/25 20:35:41, nednguyen wrote:
> > > > On 2017/01/25 18:43:58, jam wrote:
> > > > > Same question as
> > > > > https://bugs.chromium.org/p/chromium/issues/detail?id=676742#c26, if
on
> > > > > mac/windows we have multiple instances running on one machine, do we
> need
> > 4
> > > > > shards?
> > > > > 
> > > > > Also are you sure that it'll always pass in under 5 minutes? We don't
> want
> > > it
> > > > > sometimes running over and failing CQ runs because of that. Should you
> > > perhaps
> > > > > remove the hard limit part and monitor runtime to see if it needs to
be
> > > > sharded
> > > > > differently instead?
> > > > 
> > > > It takes:
> > > > 10m 36s on Mac:
> > > >
> > >
> >
>
https://chromium-swarm.appspot.com/task?id=33f01480eb4acc10&refresh=10&show_r...
> > > > (0 flaky tests)
> > > > 
> > > > 9m29s on Windows:
> > > >
> > >
> >
>
https://chromium-swarm.appspot.com/task?id=33f01305d8364a10&refresh=10&show_r...
> > > > (0 flaky tests)
> > > > 
> > > > So I can set shards = 2 for Mac & Win, wdyt?
> > > 
> > > I'd be fine w/ any number between 2 and 4. I'm not sure I see a strong
> reason
> > > not to use 4, as long as we have the resources.
> > 
> > lgtm with adding 2 for others. i think it's preferable to use 2 instead of 4
> as
> > there is overhead per shard, and not worth it if it'll run in 2-3 minutes.
> also
> > not using hard timesouts
> 
> What about adding 2 for mac/windows so they dont take 10 minutes?

Oops, I forgot to upload the latest patch.