Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(822)

Issue 2655043004: PPC/s390: [Turbofan] Implement call with spread bytecode in assembly code. (Closed)

Created:
3 years, 10 months ago by JaideepBajwa
Modified:
3 years, 10 months ago
CC:
v8-reviews_googlegroups.com
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

PPC/s390: [Turbofan] Implement call with spread bytecode in assembly code. Port f9367847b0e97e7238b4bfefbec79c8fbbc11056 Port bf782ec5124ff26d15a2bd413a4186ba20561e6d Original Commit Message: We can share almost all of the architecture-specific builtin code with super-call-with-spread. Info to port-writers: The code in CheckSpreadAndPushToStack has changed slightly from what was in Generate_ConstructWithSpread, in that we take the length of the spreaded parameters from the JSArray rather than the FixedArray backing store. R=petermarshall@chromium.org, joransiu@ca.ibm.com, jyan@ca.ibm.com, michael_dawson@ca.ibm.com BUG=v8:5511 LOG=N Review-Url: https://codereview.chromium.org/2655043004 Cr-Commit-Position: refs/heads/master@{#42708} Committed: https://chromium.googlesource.com/v8/v8/+/cc075f0e832c537f757e4d5458b9b849ba34f3d2

Patch Set 1 #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+302 lines, -254 lines) Patch
M src/builtins/ppc/builtins-ppc.cc View 3 chunks +151 lines, -127 lines 0 comments Download
M src/builtins/s390/builtins-s390.cc View 3 chunks +151 lines, -127 lines 1 comment Download

Messages

Total messages: 8 (3 generated)
JaideepBajwa
ptal
3 years, 10 months ago (2017-01-26 16:00:34 UTC) #1
john.yan
lgtm
3 years, 10 months ago (2017-01-26 16:02:25 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2655043004/1
3 years, 10 months ago (2017-01-26 16:03:01 UTC) #4
commit-bot: I haz the power
Committed patchset #1 (id:1) as https://chromium.googlesource.com/v8/v8/+/cc075f0e832c537f757e4d5458b9b849ba34f3d2
3 years, 10 months ago (2017-01-26 16:34:08 UTC) #7
john.yan
3 years, 10 months ago (2017-02-01 03:26:42 UTC) #8
Message was sent while issue was closed.
@bjaideep@ca.ibm.com

https://codereview.chromium.org/2655043004/diff/1/src/builtins/s390/builtins-...
File src/builtins/s390/builtins-s390.cc (right):

https://codereview.chromium.org/2655043004/diff/1/src/builtins/s390/builtins-...
src/builtins/s390/builtins-s390.cc:2756: __ LoadP(scratch,
FieldMemOperand(spread_map, Map::kBitField2Offset));
Use LoadB here will fix the endian issue.

Powered by Google App Engine
This is Rietveld 408576698