Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(182)

Issue 2655023009: [csa] Allow passing VariableList to BuildFastFixedArrayForEach (Closed)

Created:
3 years, 10 months ago by danno
Modified:
3 years, 10 months ago
Reviewers:
Igor Sheludko
CC:
v8-reviews_googlegroups.com
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[csa] Allow passing VariableList to BuildFastFixedArrayForEach Review-Url: https://codereview.chromium.org/2655023009 Cr-Commit-Position: refs/heads/master@{#42773} Committed: https://chromium.googlesource.com/v8/v8/+/dedc8a2f51b5d01aa3e1b58fa3c5f96f27745b42

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+15 lines, -3 lines) Patch
M src/code-stub-assembler.h View 1 chunk +12 lines, -1 line 0 comments Download
M src/code-stub-assembler.cc View 2 chunks +3 lines, -2 lines 0 comments Download

Messages

Total messages: 12 (8 generated)
danno
ptal
3 years, 10 months ago (2017-01-27 16:06:57 UTC) #4
Igor Sheludko
lgtm
3 years, 10 months ago (2017-01-30 12:29:31 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2655023009/1
3 years, 10 months ago (2017-01-30 12:32:36 UTC) #9
commit-bot: I haz the power
3 years, 10 months ago (2017-01-30 13:05:05 UTC) #12
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/v8/v8/+/dedc8a2f51b5d01aa3e1b58fa3c5f96f277...

Powered by Google App Engine
This is Rietveld 408576698