Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(45)

Issue 2655023002: Update minimum OS X version in docs for building Chrome (Closed)

Created:
3 years, 11 months ago by Paweł Hajdan Jr.
Modified:
3 years, 11 months ago
Reviewers:
Dirk Pranke, Nico
CC:
chromium-reviews, mac-reviews_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Update minimum OS X version in docs for building Chrome See https://groups.google.com/a/chromium.org/d/msg/chromium-dev/B7TY7QucDsA/2DXT2HdPAgAJ for context. BUG=none Review-Url: https://codereview.chromium.org/2655023002 Cr-Commit-Position: refs/heads/master@{#446017} Committed: https://chromium.googlesource.com/chromium/src/+/5179f42d65e1e17e8d9a89906fd533352f101f5a

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M docs/mac_build_instructions.md View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 10 (5 generated)
Paweł Hajdan Jr.
3 years, 11 months ago (2017-01-25 14:27:17 UTC) #2
Nico
lgtm
3 years, 11 months ago (2017-01-25 14:36:30 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2655023002/1
3 years, 11 months ago (2017-01-25 14:36:48 UTC) #6
commit-bot: I haz the power
Committed patchset #1 (id:1) as https://chromium.googlesource.com/chromium/src/+/5179f42d65e1e17e8d9a89906fd533352f101f5a
3 years, 11 months ago (2017-01-25 14:48:01 UTC) #9
Dirk Pranke
3 years, 11 months ago (2017-01-25 17:11:17 UTC) #10
Message was sent while issue was closed.
lgtm, thanks!

Powered by Google App Engine
This is Rietveld 408576698