Make WebString::equal take the length for const char* too

Make WebString::equal take the length for const char* too

This makes strlen calls optimized away for literal strings.

(Verified a few callsites to see the strlen actually gets replaced with
immediate values for literal strings)

BUG=667131
Review-Url: https://codereview.chromium.org/2655013004
Cr-Commit-Position: refs/heads/master@{#446322}
Committed: https://chromium.googlesource.com/chromium/src/+/56bb6b406b0a1cbfbc9b21fcbcaac6bd16e7e9a9

[kinuko, 2017-01-26 07:14:50]

The CQ bit was checked by kinuko@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-01-26 07:15:01]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[kinuko, 2017-01-26 07:15:20]

Description was changed from

==========
Make WebString::equal take the length for const char* too

This makes strlen calls optimized away for literal strings.

(Verified a few callsites to see the strlen actually gets replaced with
immediate values for literal strings)

BUG=667131
==========

to

==========
Make WebString::equal take the length for const char* too

This makes strlen calls optimized away for literal strings.

(Verified a few callsites to see the strlen actually gets replaced with
immediate values for literal strings)

BUG=667131
==========

[kinuko, 2017-01-26 07:15:21]

kinuko@chromium.org changed reviewers:
+ csharrison@chromium.org, esprehn@chromium.org

[kinuko, 2017-01-26 07:15:39]

Mind taking a look?

[esprehn, 2017-01-26 08:36:54]

You need to null check before calling strlen, lgtm w/ that fixed.

https://codereview.chromium.org/2655013004/diff/1/third_party/WebKit/public/p...
File third_party/WebKit/public/platform/WebString.h (right):

https://codereview.chromium.org/2655013004/diff/1/third_party/WebKit/public/p...
third_party/WebKit/public/platform/WebString.h:232: return a.equals(b,
strlen(b));
You need to null check, calling strlen with null will crash.

, b ? strlen(b) : 0)

https://codereview.chromium.org/2655013004/diff/1/third_party/WebKit/public/p...
third_party/WebKit/public/platform/WebString.h:240: return b.equals(a,
strlen(a));
ditto, or you could do:

return b == a;

[commit-bot: I haz the power, 2017-01-26 09:24:24]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-01-26 09:24:24]

Dry run: This issue passed the CQ dry run.

[kinuko, 2017-01-26 09:41:04]

https://codereview.chromium.org/2655013004/diff/1/third_party/WebKit/public/p...
File third_party/WebKit/public/platform/WebString.h (right):

https://codereview.chromium.org/2655013004/diff/1/third_party/WebKit/public/p...
third_party/WebKit/public/platform/WebString.h:232: return a.equals(b,
strlen(b));
On 2017/01/26 08:36:54, esprehn wrote:
> You need to null check, calling strlen with null will crash.
> 
> , b ? strlen(b) : 0)

Thanks for catching this!  Done.

https://codereview.chromium.org/2655013004/diff/1/third_party/WebKit/public/p...
third_party/WebKit/public/platform/WebString.h:240: return b.equals(a,
strlen(a));
On 2017/01/26 08:36:54, esprehn wrote:
> ditto, or you could do:
> 
> return b == a;

Done.

[kinuko, 2017-01-26 09:41:08]

The CQ bit was checked by kinuko@chromium.org

[kinuko, 2017-01-26 09:41:09]

The patchset sent to the CQ was uploaded after l-g-t-m from esprehn@chromium.org
Link to the patchset: https://codereview.chromium.org/2655013004/#ps20001
(title: "null crash fix")

[commit-bot: I haz the power, 2017-01-26 09:41:24]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-01-26 11:37:21]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-01-26 11:37:22]

Try jobs failed on following builders:
  linux_android_rel_ng on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/linux_androi...)

[kinuko, 2017-01-26 12:42:51]

The CQ bit was checked by kinuko@chromium.org

[commit-bot: I haz the power, 2017-01-26 12:43:00]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Charlie Harrison, 2017-01-26 12:51:52]

lgtm

[commit-bot: I haz the power, 2017-01-26 14:36:15]

CQ is committing da patch.

Bot data: {"patchset_id": 20001, "attempt_start_ts": 1485434571815540,
"parent_rev": "f82ec0d63125d78d32a38be642350ebc76762b4c", "commit_rev":
"56bb6b406b0a1cbfbc9b21fcbcaac6bd16e7e9a9"}

[commit-bot: I haz the power, 2017-01-26 14:36:53]

Description was changed from

==========
Make WebString::equal take the length for const char* too

This makes strlen calls optimized away for literal strings.

(Verified a few callsites to see the strlen actually gets replaced with
immediate values for literal strings)

BUG=667131
==========

to

==========
Make WebString::equal take the length for const char* too

This makes strlen calls optimized away for literal strings.

(Verified a few callsites to see the strlen actually gets replaced with
immediate values for literal strings)

BUG=667131

Review-Url: https://codereview.chromium.org/2655013004
Cr-Commit-Position: refs/heads/master@{#446322}
Committed:
https://chromium.googlesource.com/chromium/src/+/56bb6b406b0a1cbfbc9b21fcbcaa...
==========

[commit-bot: I haz the power, 2017-01-26 14:36:54]

Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/56bb6b406b0a1cbfbc9b21fcbcaa...