Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(98)

Issue 2654993009: Remove fast/storage/serialized-script-value.html and serialized-script-value-collections.html. (Closed)

Created:
3 years, 10 months ago by jbroman
Modified:
3 years, 10 months ago
Reviewers:
jsbell
CC:
blink-reviews, chromium-reviews
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Remove fast/storage/serialized-script-value.html and serialized-script-value-collections.html. These are very sensitive to changes in the wire format, and the copmatibility cases they are designed to test are covered by V8 and Blink unit tests. This makes it easier to land changes such as this one: https://codereview.chromium.org/2658793004 BUG=686159 Review-Url: https://codereview.chromium.org/2654993009 Cr-Commit-Position: refs/heads/master@{#446749} Committed: https://chromium.googlesource.com/chromium/src/+/679cd54a09a4ff192ea8bb3f5af32a73299ff0cd

Patch Set 1 #

Patch Set 2 : remove associated resources, too #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -807 lines) Patch
D third_party/WebKit/LayoutTests/fast/storage/resources/file.txt View 1 1 chunk +0 lines, -1 line 0 comments Download
D third_party/WebKit/LayoutTests/fast/storage/resources/serialized-script-value.js View 1 1 chunk +0 lines, -212 lines 0 comments Download
D third_party/WebKit/LayoutTests/fast/storage/serialized-script-value.html View 1 chunk +0 lines, -146 lines 0 comments Download
D third_party/WebKit/LayoutTests/fast/storage/serialized-script-value-collections.html View 1 chunk +0 lines, -34 lines 0 comments Download
D third_party/WebKit/LayoutTests/fast/storage/serialized-script-value-expected.txt View 1 chunk +0 lines, -414 lines 0 comments Download

Messages

Total messages: 15 (10 generated)
jbroman
Started seeing this because I wanted to send out an improvement to how 8-bit strings ...
3 years, 10 months ago (2017-01-27 18:52:00 UTC) #7
jsbell
lgtm I notice a few other uses of internals.deserializeBuffer in tests (wasm, crypto) should we ...
3 years, 10 months ago (2017-01-27 19:54:44 UTC) #8
jbroman
On 2017/01/27 at 19:54:44, jsbell wrote: > lgtm > > I notice a few other ...
3 years, 10 months ago (2017-01-27 20:12:02 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2654993009/20001
3 years, 10 months ago (2017-01-27 20:12:35 UTC) #12
commit-bot: I haz the power
3 years, 10 months ago (2017-01-27 20:19:39 UTC) #15
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/679cd54a09a4ff192ea8bb3f5af3...

Powered by Google App Engine
This is Rietveld 408576698