Remove --allow-file-access and accompanying logic

Remove --allow-file-access and accompanying logic

This flag was added long time ago in crrev.com/65866 for giving
tests unconditional access to files via file://. However, this flag
is no longer necessary because switches::kTestType (--test-type) is
checked in ChromeNetworkDelegate::OnCanAccessFile().

BUG=677933
TEST=all tests pass as before

Review-Url: https://codereview.chromium.org/2654993002
Cr-Commit-Position: refs/heads/master@{#446179}
Committed: https://chromium.googlesource.com/chromium/src/+/ab97148e15f1fecbdef8f50bed35987d8c6423ab

[satorux1, 2017-01-25 07:09:32]

The CQ bit was checked by satorux@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-01-25 07:09:48]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-01-25 08:02:20]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-01-25 08:02:20]

Dry run: This issue passed the CQ dry run.

[satorux1, 2017-01-25 08:19:10]

satorux@chromium.org changed reviewers:
+ achuith@chromium.org, eroman@chromium.org, phajdan.jr@chromium.org

[satorux1, 2017-01-25 08:19:10]

eroman: chrome/browser/net
phajdan.jr: chrome/test
achuith: chrome/browser/chromeos and chrome_switches*

[achuithb, 2017-01-25 08:45:03]

lgtm.

One of my first CLs at Google - 6 years ago!

[Paweł Hajdan Jr., 2017-01-25 11:21:11]

chrome/test LGTM

[eroman, 2017-01-25 21:42:06]

LGTM

Can you grant me view access to the bug?

[satorux1, 2017-01-26 00:44:41]

The CQ bit was checked by satorux@chromium.org

[commit-bot: I haz the power, 2017-01-26 00:45:48]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-01-26 00:54:48]

CQ is committing da patch.

Bot data: {"patchset_id": 1, "attempt_start_ts": 1485391481179300, "parent_rev":
"c96e02d34a39e6a3e790c563cb506b73aa134e2b", "commit_rev":
"ab97148e15f1fecbdef8f50bed35987d8c6423ab"}

[commit-bot: I haz the power, 2017-01-26 00:55:18]

Description was changed from

==========
Remove --allow-file-access and accompanying logic

This flag was added long time ago in crrev.com/65866 for giving
tests unconditional access to files via file://. However, this flag
is no longer necessary because switches::kTestType (--test-type) is
checked in ChromeNetworkDelegate::OnCanAccessFile().

BUG=677933
TEST=all tests pass as before
==========

to

==========
Remove --allow-file-access and accompanying logic

This flag was added long time ago in crrev.com/65866 for giving
tests unconditional access to files via file://. However, this flag
is no longer necessary because switches::kTestType (--test-type) is
checked in ChromeNetworkDelegate::OnCanAccessFile().

BUG=677933
TEST=all tests pass as before

Review-Url: https://codereview.chromium.org/2654993002
Cr-Commit-Position: refs/heads/master@{#446179}
Committed:
https://chromium.googlesource.com/chromium/src/+/ab97148e15f1fecbdef8f50bed35...
==========

[commit-bot: I haz the power, 2017-01-26 00:55:19]

Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/ab97148e15f1fecbdef8f50bed35...