platform/testing/{URL|Unit}TestHelpers improvements

third_party/WebKit/Source/platform/testing/UnitTestHelpers.h

Index: third_party/WebKit/Source/platform/testing/UnitTestHelpers.h
diff --git a/third_party/WebKit/Source/platform/testing/UnitTestHelpers.h b/third_party/WebKit/Source/platform/testing/UnitTestHelpers.h
index 92b3e2e3afd2133232d8cd131c7352812324750d..416dc7602ba06fa0c347a6c0c755b501a7fc5cba 100644
--- a/third_party/WebKit/Source/platform/testing/UnitTestHelpers.h
+++ b/third_party/WebKit/Source/platform/testing/UnitTestHelpers.h
@@ -35,21 +35,35 @@ class SharedBuffer;
 
 namespace testing {
 
+// Note: You may want to use TestingPlatformSupportWithMockScheduler to
+// provides runUntilIdle() method that can work with WebURLLoaderMockFactory.
 void runPendingTasks();
 
-// Wait for delayed task to complete or timers to fire for |delayMs|
+// Waits for delayed task to complete or timers to fire for |delayMs|
 // milliseconds.
 void runDelayedTasks(double delayMs);
 
-String blinkRootDir();
-
-PassRefPtr<SharedBuffer> readFromFile(const String& path);
-
 void enterRunLoop();
 void exitRunLoop();
 
 void yieldCurrentThread();
 
+// Returns Blink top directory as an absolute path, e.g.
+// /src/third_party/WebKit.
+String blinkRootDir();
+
+// Returns test data absolute path for webkit_unit_tests, i.e.
+// <blinkRootDir>/Source/web/tests/data/<relativePath>.
+// It returns top web test directory if |relativePath| was not specified.

[kinuko, 2017/01/27 15:50:40]

nit: top web test directory -> the top web test directory

[Takashi Toyoshima, 2017/02/06 08:14:55]

Done.

+String webTestDataPath(const String& relativePath = String());
+
+// Returns test data absolute path for blink_platform_unittests, i.e.
+// <blinkRootDir>/Source/platform/testing/data/<relativePath>.
+// It returns top platform test directory if |relativePath| was not specified.

[kinuko, 2017/01/27 15:50:40]

top ... -> the top ...

[Takashi Toyoshima, 2017/02/06 08:14:55]

Done.

+String platformTestDataPath(const String& relativePath = String());
+
+PassRefPtr<SharedBuffer> readFromFile(const String& path);
+
 }  // namespace testing
 }  // namespace blink