platform/testing/{URL|Unit}TestHelpers improvements

third_party/WebKit/Source/platform/testing/UnitTestHelpers.h

 /*
  * Copyright (C) 2013 Google Inc. All rights reserved.
  *
  * Redistribution and use in source and binary forms, with or without
  * modification, are permitted provided that the following conditions
  * are met:
  *
  * 1.  Redistributions of source code must retain the above copyright
  *     notice, this list of conditions and the following disclaimer.
  * 2.  Redistributions in binary form must reproduce the above copyright
@@ skipping 17 matching lines @@
 
 #include "wtf/PassRefPtr.h"
 #include "wtf/text/WTFString.h"
 
 namespace blink {
 
 class SharedBuffer;
 
 namespace testing {
 
+// Note: You may want to use TestingPlatformSupportWithMockScheduler to
+// provides runUntilIdle() method that can work with WebURLLoaderMockFactory.
 void runPendingTasks();
 
-// Wait for delayed task to complete or timers to fire for |delayMs|
+// Waits for delayed task to complete or timers to fire for |delayMs|
 // milliseconds.
 void runDelayedTasks(double delayMs);
 
-String blinkRootDir();
-
-PassRefPtr<SharedBuffer> readFromFile(const String& path);
-
 void enterRunLoop();
 void exitRunLoop();
 
 void yieldCurrentThread();
 
+// Returns Blink top directory as an absolute path, e.g.
+// /src/third_party/WebKit.
+String blinkRootDir();
+
+// Returns test data absolute path for webkit_unit_tests, i.e.
+// <blinkRootDir>/Source/web/tests/data/<relativePath>.
+// It returns top web test directory if |relativePath| was not specified.

[kinuko, 2017/01/27 15:50:40]

nit: top web test directory -> the top web test directory

[Takashi Toyoshima, 2017/02/06 08:14:55]

Done.

+String webTestDataPath(const String& relativePath = String());
+
+// Returns test data absolute path for blink_platform_unittests, i.e.
+// <blinkRootDir>/Source/platform/testing/data/<relativePath>.
+// It returns top platform test directory if |relativePath| was not specified.

[kinuko, 2017/01/27 15:50:40]

top ... -> the top ...

[Takashi Toyoshima, 2017/02/06 08:14:55]

Done.

+String platformTestDataPath(const String& relativePath = String());
+
+PassRefPtr<SharedBuffer> readFromFile(const String& path);
+
 }  // namespace testing
 }  // namespace blink
 
 #endif