[stubs] KeyedLoadGeneric: support loading properties from strings

[stubs] KeyedLoadGeneric: support loading properties from strings

The spec for String.split() requires loading "separator[@@split]".
The KeyedLoadIC for this goes generic right away, but still requires
a runtime call. To avoid that, reshuffle checks in the generic stub
and do the primitive-string -> String-function translation inline.

Review-Url: https://codereview.chromium.org/2654893003
Cr-Commit-Position: refs/heads/master@{#42797}
Committed: https://chromium.googlesource.com/v8/v8/+/06df8affc67db50e1d42197e3b611e152412dda5

[Jakob Kummerow, 2017-01-25 16:50:49]

jkummerow@chromium.org changed reviewers:
+ ishell@chromium.org

[Jakob Kummerow, 2017-01-25 16:50:50]

PTAL.

[Igor Sheludko, 2017-01-27 08:04:07]

https://codereview.chromium.org/2654893003/diff/20001/src/ic/accessor-assembl...
File src/ic/accessor-assembler.cc (right):

https://codereview.chromium.org/2654893003/diff/20001/src/ic/accessor-assembl...
src/ic/accessor-assembler.cc:1492: receiver = var_receiver.value();
Here we are potentially changing the receiver but receiver_map and instance_type
still correspond to original receiver. Well the latter is not used afterwards
but the former is.

[Igor Sheludko, 2017-01-27 08:13:42]

https://codereview.chromium.org/2654893003/diff/20001/src/ic/accessor-assembl...
File src/ic/accessor-assembler.cc (right):

https://codereview.chromium.org/2654893003/diff/20001/src/ic/accessor-assembl...
src/ic/accessor-assembler.cc:1493: Node* key = var_unique.value();
Moreover, we are lucky that the elements handling code is located above the
receiver node modification, otherwise CSA will complain about bad graph. Maybe
it would be cleaner if we move if_index and if_unique_name cases to separate
methods.

[Jakob Kummerow, 2017-01-28 04:30:12]

https://codereview.chromium.org/2654893003/diff/20001/src/ic/accessor-assembl...
File src/ic/accessor-assembler.cc (right):

https://codereview.chromium.org/2654893003/diff/20001/src/ic/accessor-assembl...
src/ic/accessor-assembler.cc:1492: receiver = var_receiver.value();
On 2017/01/27 08:04:07, Igor Sheludko wrote:
> Here we are potentially changing the receiver but receiver_map and
instance_type
> still correspond to original receiver. Well the latter is not used afterwards
> but the former is.

Oops, good point. Done.

https://codereview.chromium.org/2654893003/diff/20001/src/ic/accessor-assembl...
src/ic/accessor-assembler.cc:1493: Node* key = var_unique.value();
On 2017/01/27 08:13:42, Igor Sheludko wrote:
> Moreover, we are lucky that the elements handling code is located above the
> receiver node modification, otherwise CSA will complain about bad graph. Maybe
> it would be cleaner if we move if_index and if_unique_name cases to separate
> methods.

Done.

[Igor Sheludko, 2017-01-30 16:57:48]

lgtm

[Jakob Kummerow, 2017-01-30 19:02:23]

The CQ bit was checked by jkummerow@chromium.org

[commit-bot: I haz the power, 2017-01-30 19:02:32]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-01-30 19:04:16]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-01-30 19:04:17]

Try jobs failed on following builders:
  v8_linux64_gyp_rel_ng on master.tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_linux64_gyp_rel_ng/build...)
  v8_linux_mipsel_compile_rel on master.tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_linux_mipsel_compile_rel...)
  v8_linux_nodcheck_rel_ng on master.tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_linux_nodcheck_rel_ng/bu...)
  v8_presubmit on master.tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_presubmit/builds/33646)
  v8_win64_rel_ng on master.tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_win64_rel_ng/builds/21762)
  v8_win_rel_ng on master.tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_win_rel_ng/builds/21851)

[Jakob Kummerow, 2017-01-30 19:26:07]

The CQ bit was checked by jkummerow@chromium.org

[Jakob Kummerow, 2017-01-30 19:26:07]

The patchset sent to the CQ was uploaded after l-g-t-m from ishell@chromium.org
Link to the patchset: https://codereview.chromium.org/2654893003/#ps60001
(title: "rebased")

[commit-bot: I haz the power, 2017-01-30 19:26:18]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-01-30 19:45:00]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-01-30 19:45:01]

Try jobs failed on following builders:
  v8_linux_dbg_ng on master.tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_linux_dbg_ng/builds/20213)
  v8_linux_dbg_ng_triggered on master.tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_linux_dbg_ng_triggered/b...)
  v8_linux_verify_csa_rel_ng on master.tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_linux_verify_csa_rel_ng/...)
  v8_linux_verify_csa_rel_ng_triggered on master.tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_linux_verify_csa_rel_ng_...)

[Jakob Kummerow, 2017-01-31 00:31:57]

The CQ bit was checked by jkummerow@chromium.org

[Jakob Kummerow, 2017-01-31 00:31:58]

The patchset sent to the CQ was uploaded after l-g-t-m from ishell@chromium.org
Link to the patchset: https://codereview.chromium.org/2654893003/#ps80001
(title: "fix typo in CSA_ASSERT")

[commit-bot: I haz the power, 2017-01-31 00:32:04]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-01-31 01:19:47]

CQ is committing da patch.

Bot data: {"patchset_id": 80001, "attempt_start_ts": 1485822717793630,
"parent_rev": "d6db11fd181061f9ffce4431af5afec0dba2c82c", "commit_rev":
"06df8affc67db50e1d42197e3b611e152412dda5"}

[commit-bot: I haz the power, 2017-01-31 01:19:51]

Description was changed from

==========
[stubs] KeyedLoadGeneric: support loading properties from strings

The spec for String.split() requires loading "separator[@@split]".
The KeyedLoadIC for this goes generic right away, but still requires
a runtime call. To avoid that, reshuffle checks in the generic stub
and do the primitive-string -> String-function translation inline.
==========

to

==========
[stubs] KeyedLoadGeneric: support loading properties from strings

The spec for String.split() requires loading "separator[@@split]".
The KeyedLoadIC for this goes generic right away, but still requires
a runtime call. To avoid that, reshuffle checks in the generic stub
and do the primitive-string -> String-function translation inline.

Review-Url: https://codereview.chromium.org/2654893003
Cr-Commit-Position: refs/heads/master@{#42797}
Committed:
https://chromium.googlesource.com/v8/v8/+/06df8affc67db50e1d42197e3b611e15241...
==========

[commit-bot: I haz the power, 2017-01-31 01:19:52]

Committed patchset #5 (id:80001) as
https://chromium.googlesource.com/v8/v8/+/06df8affc67db50e1d42197e3b611e15241...