Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(447)

Issue 2654883002: Give OOPIF FrameViews their own scroll animation timelines and hosts (Closed)

Created:
3 years, 11 months ago by kenrb
Modified:
3 years, 11 months ago
Reviewers:
CC:
chromium-reviews
Target Ref:
refs/pending/branch-heads/2987
Project:
chromium
Visibility:
Public.

Description

Give OOPIF FrameViews their own scroll animation timelines and hosts OOPIFs need independent scroll animation timelines and hosts, because they have separate compositors. Ultimately we need to associate a ScrollingCoordinator which each local frame root, but until that work is done this CL resolves some known scrolling problems in --site-per-process mode. BUG=675695 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2 Review-Url: https://codereview.chromium.org/2631853002 Cr-Commit-Position: refs/heads/master@{#444947} (cherry picked from commit 65c7df6e695eb4435ccf5485498b34fd1629f898) Review-Url: https://codereview.chromium.org/2654883002 . Cr-Commit-Position: refs/branch-heads/2987@{#62} Cr-Branched-From: ad51088c0e8776e8dcd963dbe752c4035ba6dab6-refs/heads/master@{#444943} Committed: https://chromium.googlesource.com/chromium/src/+/66ec94ea64f65f9d305390b7636bb49ad00b508c

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+205 lines, -34 lines) Patch
A third_party/WebKit/LayoutTests/http/tests/misc/resources/cross-origin-subframe-for-scrolling.html View 1 chunk +28 lines, -0 lines 0 comments Download
A third_party/WebKit/LayoutTests/http/tests/misc/scroll-cross-origin-iframes.html View 1 chunk +44 lines, -0 lines 0 comments Download
A third_party/WebKit/LayoutTests/http/tests/misc/scroll-cross-origin-iframes-expected.txt View 1 chunk +11 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/core/frame/FrameView.h View 3 chunks +14 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/core/frame/FrameView.cpp View 2 chunks +29 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/core/frame/VisualViewport.cpp View 1 chunk +2 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/core/page/Page.h View 1 chunk +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/core/page/Page.cpp View 1 chunk +6 lines, -4 lines 0 comments Download
M third_party/WebKit/Source/core/page/scrolling/ScrollingCoordinator.h View 1 chunk +6 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/core/page/scrolling/ScrollingCoordinator.cpp View 2 chunks +37 lines, -9 lines 0 comments Download
M third_party/WebKit/Source/core/paint/PaintLayerScrollableArea.cpp View 1 chunk +2 lines, -8 lines 0 comments Download
M third_party/WebKit/Source/web/WebFrameWidgetImpl.cpp View 2 chunks +8 lines, -4 lines 0 comments Download
M third_party/WebKit/Source/web/WebPagePopupImpl.cpp View 2 chunks +14 lines, -3 lines 0 comments Download
M third_party/WebKit/Source/web/WebViewImpl.cpp View 2 chunks +2 lines, -2 lines 0 comments Download

Messages

Total messages: 2 (1 generated)
kenrb
3 years, 11 months ago (2017-01-24 18:27:35 UTC) #2
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
66ec94ea64f65f9d305390b7636bb49ad00b508c.

Powered by Google App Engine
This is Rietveld 408576698