Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(27)

Issue 2654873003: Make logging in test_importer.py quieter. (Closed)

Created:
3 years, 11 months ago by qyearsley
Modified:
3 years, 11 months ago
Reviewers:
jeffcarp
CC:
blink-reviews, blink-reviews-w3ctests_chromium.org, chromium-reviews, Dirk Pranke, tfarina
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Make logging in test_importer.py quieter. Reason: Currently, files may be skipped when importing, but the reason why they're skipped is buried in hundreds of lines of logging. This CL changes logging so that all entries listing individual files and directories in normal operation are changed to "debug" level. BUG=684029 Review-Url: https://codereview.chromium.org/2654873003 Cr-Commit-Position: refs/heads/master@{#445798} Committed: https://chromium.googlesource.com/chromium/src/+/76cbd1cf8bb3c100994df4d28a8357008428ea8f

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -5 lines) Patch
M third_party/WebKit/Tools/Scripts/webkitpy/w3c/test_importer.py View 4 chunks +5 lines, -5 lines 0 comments Download

Messages

Total messages: 8 (4 generated)
qyearsley
3 years, 11 months ago (2017-01-24 18:31:27 UTC) #2
jeffcarp
lgtm
3 years, 11 months ago (2017-01-24 19:28:50 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2654873003/1
3 years, 11 months ago (2017-01-24 19:30:50 UTC) #5
commit-bot: I haz the power
3 years, 11 months ago (2017-01-24 20:44:52 UTC) #8
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/76cbd1cf8bb3c100994df4d28a83...

Powered by Google App Engine
This is Rietveld 408576698