Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(953)

Unified Diff: ui/gfx/canvas.h

Issue 2654853002: Remove gfx::Canvas::DrawStringRectWithHalo. (Closed)
Patch Set: Created 3 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: ui/gfx/canvas.h
diff --git a/ui/gfx/canvas.h b/ui/gfx/canvas.h
index c81c0f25db78fdb90fb52d106137e43d384a92bc..0be86f0cd85fa8616d750ee907ee11c1924658ec 100644
--- a/ui/gfx/canvas.h
+++ b/ui/gfx/canvas.h
@@ -73,9 +73,6 @@ class GFX_EXPORT Canvas {
// when rendering text onto a fully- or partially-transparent background
// that will later be blended with another image.
NO_SUBPIXEL_RENDERING = 1 << 9,
-
- // Draw text with 1px border.
- HALO_EFFECT = 1 << 10,
};
// Creates an empty canvas with image_scale of 1x.
@@ -148,22 +145,6 @@ class GFX_EXPORT Canvas {
// Canvas::TEXT_ALIGN_RIGHT.
static int DefaultCanvasTextAlignment();
- // Draws text with a 1-pixel halo around it of the given color.
- // On Windows, it allows ClearType to be drawn to an otherwise transparent
- // bitmap for drag images. Drag images have only 1-bit of transparency, so
- // we don't do any fancy blurring.
- // On Linux, text with halo is created by stroking it with 2px |halo_color|
- // then filling it with |text_color|.
- // On Mac, NOTIMPLEMENTED.
- // TODO(dhollowa): Skia-native implementation is underway. Cut over to
- // that when ready. http::/crbug.com/109946
- void DrawStringRectWithHalo(const base::string16& text,
- const FontList& font_list,
- SkColor text_color,
- SkColor halo_color,
- const Rect& display_rect,
- int flags);
-
// Extracts an ImageSkiaRep from the contents of this canvas.
ImageSkiaRep ExtractImageRep() const;

Powered by Google App Engine
This is Rietveld 408576698