Remove gfx::Canvas::DrawStringRectWithHalo.

ui/gfx/render_text.cc

Index: ui/gfx/render_text.cc
diff --git a/ui/gfx/render_text.cc b/ui/gfx/render_text.cc
index a0dbb0baa4511a52fce724d225a46c1f1324d4b7..bfe29525b4c37a1701b7c85c2ede1b8a974fb3b3 100644
--- a/ui/gfx/render_text.cc
+++ b/ui/gfx/render_text.cc
@@ -252,10 +252,6 @@ void SkiaTextRenderer::SetShader(sk_sp<SkShader> shader) {
   paint_.setShader(std::move(shader));
 }
 
-void SkiaTextRenderer::SetHaloEffect() {
-  paint_.setImageFilter(SkDilateImageFilter::Make(1, 1, nullptr));
-}
-
 void SkiaTextRenderer::SetUnderlineMetrics(SkScalar thickness,
                                            SkScalar position) {
   underline_thickness_ = thickness;
@@ -865,8 +861,6 @@ void RenderText::Draw(Canvas* canvas) {
 
   if (!text().empty()) {
     internal::SkiaTextRenderer renderer(canvas);

[msw, 2017/01/25 18:09:07]

nit: inline |renderer| and remove curlies

[Evan Stade, 2017/01/26 00:43:10]

I don't think I can do that --- how does one take the address of a temporary
without breaking the compile?

[msw, 2017/01/26 00:52:09]

Ah, I missed that; disregard my comment.

-    if (halo_effect())
-      renderer.SetHaloEffect();
     DrawVisualText(&renderer);
   }