Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(579)

Unified Diff: third_party/WebKit/Source/core/layout/LayoutBlockFlow.cpp

Issue 2654843004: Fix shouldPaint issue when a composited floating iframe becomes non-self-painting (Closed)
Patch Set: -0 Created 3 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/core/layout/LayoutBlockFlow.cpp
diff --git a/third_party/WebKit/Source/core/layout/LayoutBlockFlow.cpp b/third_party/WebKit/Source/core/layout/LayoutBlockFlow.cpp
index 49d25e0e6202d58062c54e21c0851061e72b01a4..5bfc1184243596c90fb20540664da794781d1ff6 100644
--- a/third_party/WebKit/Source/core/layout/LayoutBlockFlow.cpp
+++ b/third_party/WebKit/Source/core/layout/LayoutBlockFlow.cpp
@@ -3998,7 +3998,8 @@ bool LayoutBlockFlow::hitTestFloats(HitTestResult& result,
for (FloatingObjectSetIterator it = floatingObjectSet.end(); it != begin;) {
--it;
const FloatingObject& floatingObject = *it->get();
- if (floatingObject.shouldPaint()) {
+ if (floatingObject.shouldPaint() &&
+ !floatingObject.layoutObject()->hasSelfPaintingLayer()) {
chrishtr 2017/01/25 20:47:57 Why do you need this?
Xianzhu 2017/01/25 21:03:25 This is a part of the revert, which I didn't look
LayoutUnit xOffset = xPositionForFloatIncludingMargin(floatingObject) -
floatingObject.layoutObject()->location().x();
LayoutUnit yOffset = yPositionForFloatIncludingMargin(floatingObject) -

Powered by Google App Engine
This is Rietveld 408576698