Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(65)

Issue 2654703002: Rename showVirtualKeyboard() to showVirtualKeyboardOnElementFocus(). (Closed)

Created:
3 years, 11 months ago by Łukasz Anforowicz
Modified:
3 years, 11 months ago
Reviewers:
dcheng, nasko
CC:
chromium-reviews, mlamouri+watch-content_chromium.org, sof, creis+watch_chromium.org, eae+blinkwatch, nasko+codewatch_chromium.org, jam, blink-reviews-dom_chromium.org, dglazkov+blink, darin-cc_chromium.org, blink-reviews, kinuko+watch, blink-reviews-api_chromium.org, rwlbuis, please use gerrit instead, Changwan Ryu
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Rename showVirtualKeyboard() to showVirtualKeyboardOnElementFocus(). The rename is needed to avoid conflicts with RenderWidget::ShowVirtualKeyboard after the Great Blink Rename. BUG=682740 TBR=nasko@chromium.org Review-Url: https://codereview.chromium.org/2654703002 Cr-Commit-Position: refs/heads/master@{#445817} Committed: https://chromium.googlesource.com/chromium/src/+/86f05da3c1fe8ca3d242e96c8717dcdb69950f6c

Patch Set 1 #

Patch Set 2 : Fixing Android-specific compile error in render_widget_input_handler.cc #

Unified diffs Side-by-side diffs Delta from patch set Stats (+16 lines, -14 lines) Patch
M content/renderer/input/render_widget_input_handler.cc View 1 1 chunk +1 line, -1 line 0 comments Download
M content/renderer/render_view_impl.h View 1 chunk +1 line, -1 line 0 comments Download
M content/renderer/render_view_impl.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M content/renderer/render_widget.h View 1 chunk +1 line, -1 line 0 comments Download
M content/renderer/render_widget.cc View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/dom/Element.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/page/ChromeClient.h View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/web/ChromeClientImpl.h View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/web/ChromeClientImpl.cpp View 1 chunk +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/web/tests/ImeOnFocusTest.cpp View 1 chunk +3 lines, -1 line 0 comments Download
M third_party/WebKit/public/web/WebViewClient.h View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/public/web/WebWidgetClient.h View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 19 (14 generated)
Łukasz Anforowicz
dcheng@, can you PTAL?
3 years, 11 months ago (2017-01-24 16:03:41 UTC) #10
dcheng
lgtm
3 years, 11 months ago (2017-01-24 21:05:46 UTC) #11
Łukasz Anforowicz
nasko@, I'll just TBR you for //content, because this CL is just a mechanical rename ...
3 years, 11 months ago (2017-01-24 21:15:18 UTC) #14
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2654703002/20001
3 years, 11 months ago (2017-01-24 21:16:40 UTC) #16
commit-bot: I haz the power
3 years, 11 months ago (2017-01-24 21:24:04 UTC) #19
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/86f05da3c1fe8ca3d242e96c8717...

Powered by Google App Engine
This is Rietveld 408576698