Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(271)

Issue 2654673003: Implement should().beRejectedWith() (Closed)

Created:
3 years, 10 months ago by hongchan
Modified:
3 years, 10 months ago
Reviewers:
Raymond Toy
CC:
chromium-reviews, blink-reviews, kinuko+watch, Raymond Toy, hongchan
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

This CL adds should().beRejectedWith() so you can specify the expected error type. BUG=678723 TEST= LayoutTests/webaudio/unit-tests/audit.html LayoutTests/webaudio/unit-tests/audit-failures.html Review-Url: https://codereview.chromium.org/2654673003 Cr-Commit-Position: refs/heads/master@{#445617} Committed: https://chromium.googlesource.com/chromium/src/+/9f0467f5ac93ea19f8ded30cf82fc68f538e7ad1

Patch Set 1 : Initial patch #

Total comments: 4

Patch Set 2 : Addressing feedback #

Patch Set 3 : Fixed expected results #

Unified diffs Side-by-side diffs Delta from patch set Stats (+44 lines, -5 lines) Patch
M third_party/WebKit/LayoutTests/webaudio/resources/audit.js View 1 1 chunk +33 lines, -0 lines 0 comments Download
M third_party/WebKit/LayoutTests/webaudio/unit-tests/audit.html View 1 chunk +3 lines, -1 line 0 comments Download
M third_party/WebKit/LayoutTests/webaudio/unit-tests/audit-expected.txt View 1 2 1 chunk +2 lines, -1 line 0 comments Download
M third_party/WebKit/LayoutTests/webaudio/unit-tests/audit-failures.html View 1 1 chunk +3 lines, -1 line 0 comments Download
M third_party/WebKit/LayoutTests/webaudio/unit-tests/audit-failures-expected.txt View 1 2 1 chunk +3 lines, -2 lines 0 comments Download

Messages

Total messages: 15 (9 generated)
hongchan
PTAL.
3 years, 10 months ago (2017-01-23 23:07:36 UTC) #4
Raymond Toy
https://codereview.chromium.org/2654673003/diff/20001/third_party/WebKit/LayoutTests/webaudio/resources/audit.js File third_party/WebKit/LayoutTests/webaudio/resources/audit.js (right): https://codereview.chromium.org/2654673003/diff/20001/third_party/WebKit/LayoutTests/webaudio/resources/audit.js#newcode363 third_party/WebKit/LayoutTests/webaudio/resources/audit.js:363: * should('My promise', promise).beRejectedWith('_ERROR_').then(); This is backward, right? |promise| ...
3 years, 10 months ago (2017-01-23 23:11:57 UTC) #5
hongchan
https://codereview.chromium.org/2654673003/diff/20001/third_party/WebKit/LayoutTests/webaudio/resources/audit.js File third_party/WebKit/LayoutTests/webaudio/resources/audit.js (right): https://codereview.chromium.org/2654673003/diff/20001/third_party/WebKit/LayoutTests/webaudio/resources/audit.js#newcode363 third_party/WebKit/LayoutTests/webaudio/resources/audit.js:363: * should('My promise', promise).beRejectedWith('_ERROR_').then(); On 2017/01/23 23:11:57, Raymond Toy ...
3 years, 10 months ago (2017-01-23 23:14:50 UTC) #6
Raymond Toy
lgtm
3 years, 10 months ago (2017-01-23 23:45:52 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2654673003/60001
3 years, 10 months ago (2017-01-24 01:34:04 UTC) #12
commit-bot: I haz the power
3 years, 10 months ago (2017-01-24 02:44:12 UTC) #15
Message was sent while issue was closed.
Committed patchset #3 (id:60001) as
https://chromium.googlesource.com/chromium/src/+/9f0467f5ac93ea19f8ded30cf82f...

Powered by Google App Engine
This is Rietveld 408576698