Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
2654673002:
Add ftplugin for gn filetype (Closed)
|
Created:
3 years, 11 months ago by Nate Fischer Modified:
3 years, 11 months ago Reviewers:
scottmg CC:
agrieve+watch_chromium.org, chromium-reviews, Dirk Pranke, Paweł Hajdan Jr., tfarina Target Ref:
refs/pending/heads/master Project:
chromium Visibility:
Public. |
DescriptionAdd ftplugin for gn filetype
The 'includeexpr' setting (and corresponding autoload function) allows
users to jump from one gn file to another with the 'gf' command (as long
as vim's cwd is set to /src/).
The commentstring setting lets vim know what the correct comments are
for gn files (this integrates nicely with plugins like vim-commentary).
BUG=
Review-Url: https://codereview.chromium.org/2654673002
Cr-Commit-Position: refs/heads/master@{#445782}
Committed: https://chromium.googlesource.com/chromium/src/+/23449b77810518956542fb0b65be9da863e8492a
Patch Set 1 #
Total comments: 2
Patch Set 2 : Remove maktaba dependency #
Messages
Total messages: 19 (8 generated)
ntfschr@chromium.org changed reviewers: + scottmg@chromium.org
PTAL
Awesome, having gf look to a network path has always aggravated me. https://codereview.chromium.org/2654673002/diff/1/tools/gn/misc/vim/autoload/... File tools/gn/misc/vim/autoload/gn.vim (right): https://codereview.chromium.org/2654673002/diff/1/tools/gn/misc/vim/autoload/... tools/gn/misc/vim/autoload/gn.vim:13: " installed, there's not much we can do here This seems a bit defeatist. Surely we could append "BUILD.gn" with a relatively simple conditional without requiring this large dependency in the case of .gn files?
PTAL https://codereview.chromium.org/2654673002/diff/1/tools/gn/misc/vim/autoload/... File tools/gn/misc/vim/autoload/gn.vim (right): https://codereview.chromium.org/2654673002/diff/1/tools/gn/misc/vim/autoload/... tools/gn/misc/vim/autoload/gn.vim:13: " installed, there's not much we can do here On 2017/01/24 at 04:22:58, scottmg wrote: > This seems a bit defeatist. Surely we could append "BUILD.gn" with a relatively simple conditional without requiring this large dependency in the case of .gn files? Ok, I think I found a robust way to do it without the maktaba dep.
Thanks! lgtm
Thanks! lgtm
Oh, just update the CL description before landing.
Description was changed from ========== Add ftplugin for gn filetype The 'includeexpr' setting (and corresponding autoload function) allows users to jump from one gn file to another with the 'gf' command. The autoload function mostly depends on the vim-maktaba plugin, so this displays a warning message to users who do not have it installed. The commentstring setting lets vim know what the correct comments are for gn files (this integrates nicely with plugins like vim-commentary). BUG= ========== to ========== Add ftplugin for gn filetype The 'includeexpr' setting (and corresponding autoload function) allows users to jump from one gn file to another with the 'gf' command. The commentstring setting lets vim know what the correct comments are for gn files (this integrates nicely with plugins like vim-commentary). BUG= ==========
Description was changed from ========== Add ftplugin for gn filetype The 'includeexpr' setting (and corresponding autoload function) allows users to jump from one gn file to another with the 'gf' command. The commentstring setting lets vim know what the correct comments are for gn files (this integrates nicely with plugins like vim-commentary). BUG= ========== to ========== Add ftplugin for gn filetype The 'includeexpr' setting (and corresponding autoload function) allows users to jump from one gn file to another with the 'gf' command (as long as vim's cwd is set to /src/). The commentstring setting lets vim know what the correct comments are for gn files (this integrates nicely with plugins like vim-commentary). BUG= ==========
On 2017/01/24 at 18:20:32, scottmg wrote: > Oh, just update the CL description before landing. Updated. This last patch requires users to keep vim's cwd at /src/ in order for this to work (so 'autochdir' would break this). Maktaba's probably the most reliable approach, but this sort of works.
The CQ bit was checked by ntfschr@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
yolandyan@chromium.org changed reviewers: + yolandyan@chromium.org
yolandyan@chromium.org changed reviewers: - yolandyan@chromium.org
CQ is committing da patch.
Bot data: {"patchset_id": 20001, "attempt_start_ts": 1485286077774300,
"parent_rev": "2d6720b079b98fb9104c7274ef033a08d9e68efc", "commit_rev":
"23449b77810518956542fb0b65be9da863e8492a"}
Message was sent while issue was closed.
Description was changed from ========== Add ftplugin for gn filetype The 'includeexpr' setting (and corresponding autoload function) allows users to jump from one gn file to another with the 'gf' command (as long as vim's cwd is set to /src/). The commentstring setting lets vim know what the correct comments are for gn files (this integrates nicely with plugins like vim-commentary). BUG= ========== to ========== Add ftplugin for gn filetype The 'includeexpr' setting (and corresponding autoload function) allows users to jump from one gn file to another with the 'gf' command (as long as vim's cwd is set to /src/). The commentstring setting lets vim know what the correct comments are for gn files (this integrates nicely with plugins like vim-commentary). BUG= Review-Url: https://codereview.chromium.org/2654673002 Cr-Commit-Position: refs/heads/master@{#445782} Committed: https://chromium.googlesource.com/chromium/src/+/23449b77810518956542fb0b65be... ==========
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as https://chromium.googlesource.com/chromium/src/+/23449b77810518956542fb0b65be...
Message was sent while issue was closed.
On 2017/01/24 19:17:23, Nate Fischer wrote: > On 2017/01/24 at 18:20:32, scottmg wrote: > > Oh, just update the CL description before landing. > > Updated. This last patch requires users to keep vim's cwd at /src/ in order for > this to work (so 'autochdir' would break this). Maktaba's probably the most > reliable approach, but this sort of works. OK. Maybe make this the fallback case if maktaba isn't available?
Message was sent while issue was closed.
On 2017/01/24 at 21:04:17, scottmg wrote: > On 2017/01/24 19:17:23, Nate Fischer wrote: > > On 2017/01/24 at 18:20:32, scottmg wrote: > > > Oh, just update the CL description before landing. > > > > Updated. This last patch requires users to keep vim's cwd at /src/ in order for > > this to work (so 'autochdir' would break this). Maktaba's probably the most > > reliable approach, but this sort of works. > > OK. Maybe make this the fallback case if maktaba isn't available? I'll take a look into it. |
|||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
