Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1137)

Issue 2654663006: MD Settings: Update Autofill Address Dialog to accept Enter Key (Closed)

Created:
3 years, 11 months ago by tommycli
Modified:
3 years, 11 months ago
Reviewers:
hcarmona
CC:
chromium-reviews, michaelpg+watch-md-settings_chromium.org, michaelpg+watch-md-ui_chromium.org, dbeam+watch-settings_chromium.org, stevenjb+watch-md-settings_chromium.org, arv+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

MD Settings: Update Autofill Address Dialog to accept Enter Key BUG=622816 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation Review-Url: https://codereview.chromium.org/2654663006 Cr-Commit-Position: refs/heads/master@{#445831} Committed: https://chromium.googlesource.com/chromium/src/+/5d586aa2a68a7a5c4051e7a0a0ecc8a925414576

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+12 lines, -1 line) Patch
M chrome/browser/resources/settings/passwords_and_forms_page/address_edit_dialog.html View 3 chunks +8 lines, -1 line 0 comments Download
M chrome/browser/resources/settings/passwords_and_forms_page/address_edit_dialog.js View 1 chunk +4 lines, -0 lines 0 comments Download

Messages

Total messages: 14 (10 generated)
tommycli
hcarmona: PTAL, thanks!
3 years, 11 months ago (2017-01-24 21:32:27 UTC) #8
hcarmona
lgtm
3 years, 11 months ago (2017-01-24 21:52:21 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2654663006/1
3 years, 11 months ago (2017-01-24 21:57:28 UTC) #11
commit-bot: I haz the power
3 years, 11 months ago (2017-01-24 22:05:53 UTC) #14
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/5d586aa2a68a7a5c4051e7a0a0ec...

Powered by Google App Engine
This is Rietveld 408576698