Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(30)

Issue 2654653002: Handle floating point coordinates from ozone to exosphere (Closed)

Created:
3 years, 11 months ago by denniskempin (chromium)
Modified:
3 years, 11 months ago
Reviewers:
skau
CC:
chromium-reviews
Target Ref:
refs/pending/branch-heads/2987
Project:
chromium
Visibility:
Public.

Description

Handle floating point coordinates from ozone to exosphere Most touch coordinate handling within chrome is done with gfx:Points. Rounding to points works well for most cases, but really degrades user experience for hand writing with an on-screen stylus. This change will add variants to a couple of coordinate transformation methods that will use gfx::PointF instead of gfx::Point. This allows touch coordinates to be passed from ozone to exosphere in sub-pixel accuracy, allowing those coordinates to be used in arc++ note taking apps. BUG=681235 TEST=Test with arc++ drawing apps without smoothing. Lines should be smooth without distinct steps. NOPRESUBMIT=true NOTRY=true Review-Url: https://codereview.chromium.org/2648583003 Cr-Commit-Position: refs/heads/master@{#445510} (cherry picked from commit 951e1c2407a8055588e51f2f7768f034c32b3e06) Review-Url: https://codereview.chromium.org/2654653002 Cr-Commit-Position: refs/branch-heads/2987@{#43} Cr-Branched-From: ad51088c0e8776e8dcd963dbe752c4035ba6dab6-refs/heads/master@{#444943} Committed: https://chromium.googlesource.com/chromium/src/+/460a6b800eeacd57e0c61d144a919688522e7e6f

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+101 lines, -48 lines) Patch
M components/exo/touch.cc View 3 chunks +13 lines, -8 lines 0 comments Download
M components/exo/touch_delegate.h View 3 chunks +3 lines, -3 lines 0 comments Download
M components/exo/touch_unittest.cc View 14 chunks +22 lines, -22 lines 0 comments Download
M components/exo/wayland/server.cc View 2 chunks +6 lines, -6 lines 0 comments Download
M ui/events/cocoa/events_mac.mm View 1 chunk +6 lines, -2 lines 0 comments Download
M ui/events/cocoa/events_mac_unittest.mm View 5 chunks +14 lines, -0 lines 0 comments Download
M ui/events/event.cc View 1 chunk +2 lines, -3 lines 0 comments Download
M ui/events/event_utils.h View 1 chunk +2 lines, -0 lines 0 comments Download
M ui/events/events_default.cc View 1 chunk +8 lines, -0 lines 0 comments Download
M ui/events/events_stub.cc View 1 chunk +5 lines, -0 lines 0 comments Download
M ui/events/win/events_win.cc View 1 chunk +4 lines, -0 lines 0 comments Download
M ui/events/x/events_x.cc View 1 chunk +4 lines, -0 lines 0 comments Download
M ui/events/x/events_x_unittest.cc View 5 chunks +10 lines, -0 lines 0 comments Download
M ui/ozone/platform/wayland/wayland_pointer_unittest.cc View 1 chunk +2 lines, -4 lines 0 comments Download

Messages

Total messages: 8 (4 generated)
denniskempin (chromium)
3 years, 11 months ago (2017-01-23 22:33:51 UTC) #2
skau
lgtm
3 years, 11 months ago (2017-01-23 22:34:49 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2654653002/1
3 years, 11 months ago (2017-01-23 22:35:20 UTC) #5
commit-bot: I haz the power
3 years, 11 months ago (2017-01-23 22:37:28 UTC) #8
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/460a6b800eeacd57e0c61d144a91...

Powered by Google App Engine
This is Rietveld 408576698