Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2)

Issue 2654643003: Changing webrtc.gni location under webrtc (Closed)

Created:
3 years, 11 months ago by mbonadei1
Modified:
3 years, 10 months ago
CC:
chromium-reviews
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

We are moving the content of the folder "webrtc/build" to other locations in order to solve this issue (crbug.com/611808). This CL is changing the path to the webrtc.gni file. This is the second step in a 3 steps process: - on webrtc we have already moved the file but we are keeping a file at the old location which includes the file at the new location - we change the paths with this CL - we will remove the old webrtc.gni file under webrtc BUG=webrtc:7030 Review-Url: https://codereview.chromium.org/2654643003 Cr-Commit-Position: refs/heads/master@{#446368} Committed: https://chromium.googlesource.com/chromium/src/+/9a9672d96b9ed7a2d56ebcca0e84fb8b0825fa8e

Patch Set 1 #

Patch Set 2 : Changing webrtc.gni location also under content/ #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -3 lines) Patch
M content/public/common/BUILD.gn View 1 1 chunk +1 line, -1 line 0 comments Download
M content/renderer/BUILD.gn View 1 1 chunk +1 line, -1 line 0 comments Download
M third_party/libjingle_xmpp/BUILD.gn View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 16 (8 generated)
mbonadei1
It seems that the webrtc.gni file is also mentioned in the following files: - content/public/common/BUILD.gn ...
3 years, 11 months ago (2017-01-24 15:03:32 UTC) #2
kjellander_chromium
On 2017/01/24 15:03:32, mbonadei1 wrote: > It seems that the webrtc.gni file is also mentioned ...
3 years, 11 months ago (2017-01-24 21:41:47 UTC) #3
jochen (gone - plz use gerrit)
lgtm once kjellander also approves
3 years, 11 months ago (2017-01-25 12:22:58 UTC) #6
kjellander_chromium
lgtm
3 years, 11 months ago (2017-01-25 14:07:56 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2654643003/20001
3 years, 10 months ago (2017-01-26 13:34:25 UTC) #9
commit-bot: I haz the power
Try jobs failed on following builders: cast_shell_linux on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/cast_shell_linux/builds/298729) linux_chromium_chromeos_ozone_rel_ng on master.tryserver.chromium.linux (JOB_FAILED, ...
3 years, 10 months ago (2017-01-26 13:37:41 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2654643003/20001
3 years, 10 months ago (2017-01-26 16:38:29 UTC) #13
commit-bot: I haz the power
3 years, 10 months ago (2017-01-26 17:42:22 UTC) #16
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/9a9672d96b9ed7a2d56ebcca0e84...

Powered by Google App Engine
This is Rietveld 408576698