Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(176)

Issue 2654583002: Closes https://github.com/dart-lang/sdk/issues/28291 (Closed)

Created:
3 years, 11 months ago by Jacob
Modified:
3 years, 11 months ago
Reviewers:
vsm
CC:
dev-compiler+reviews_dartlang.org
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Closes https://github.com/dart-lang/sdk/issues/28291 Fix extending a JS class and add a test to ensure it continues to work from DDC. Note this behavior will never be supported in Dartium and is not yet supported by Dart2JS. BUG= R=vsm@google.com Committed: https://github.com/dart-lang/sdk/commit/d6063ca39125d61200317f0724326b0025eeb2e6

Patch Set 1 #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+58 lines, -1 line) Patch
M pkg/dev_compiler/lib/src/compiler/code_generator.dart View 1 chunk +1 line, -1 line 1 comment Download
A tests/lib_strong/html/js_extend_class_test.dart View 1 chunk +57 lines, -0 lines 0 comments Download

Messages

Total messages: 5 (2 generated)
Jacob
3 years, 11 months ago (2017-01-23 18:39:53 UTC) #2
vsm
lgtm https://codereview.chromium.org/2654583002/diff/1/pkg/dev_compiler/lib/src/compiler/code_generator.dart File pkg/dev_compiler/lib/src/compiler/code_generator.dart (right): https://codereview.chromium.org/2654583002/diff/1/pkg/dev_compiler/lib/src/compiler/code_generator.dart#newcode1265 pkg/dev_compiler/lib/src/compiler/code_generator.dart:1265: basetypes.map((t) => _emitConstructorAccess(t, nameType: false)).toList(); nit: run format.
3 years, 11 months ago (2017-01-23 20:45:03 UTC) #3
Jacob
3 years, 11 months ago (2017-01-24 15:20:38 UTC) #5
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
d6063ca39125d61200317f0724326b0025eeb2e6 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698