pkg/dev_compiler/lib/src/compiler/code_generator.dart - Issue 2654583002: Closes https://github.com/dart-lang/sdk/issues/28291

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: pkg/dev_compiler/lib/src/compiler/code_generator.dart

Issue 2654583002: Closes https://github.com/dart-lang/sdk/issues/28291 (Closed)

Patch Set: Created 3 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: pkg/dev_compiler/lib/src/compiler/code_generator.dart

diff --git a/pkg/dev_compiler/lib/src/compiler/code_generator.dart b/pkg/dev_compiler/lib/src/compiler/code_generator.dart

index 3832ea07c73897023fbb6b5cea1fd767915f992c..f558b118fe81fa4490c35f28b74b8b639dbb4a97 100644

--- a/pkg/dev_compiler/lib/src/compiler/code_generator.dart

+++ b/pkg/dev_compiler/lib/src/compiler/code_generator.dart

@@ -1262,7 +1262,7 @@ class CodeGenerator extends GeneralizingAstVisitor

// List of "direct" JS superclasses

var baseclasses =

- basetypes.map((t) => _emitType(t, nameType: false)).toList();

+ basetypes.map((t) => _emitConstructorAccess(t, nameType: false)).toList();

vsm 2017/01/23 20:45:03 nit: run format.

assert(baseclasses.isNotEmpty);

var heritage = (baseclasses.length == 1)

? baseclasses.first

« no previous file with comments | « no previous file | tests/lib_strong/html/js_extend_class_test.dart » ('j') | no next file with comments »