Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(97)

Issue 2654553004: MD Settings: Update Autofill Credit Card Dialog to accept Enter Key (Closed)

Created:
3 years, 11 months ago by tommycli
Modified:
3 years, 11 months ago
Reviewers:
hcarmona
CC:
chromium-reviews, michaelpg+watch-md-settings_chromium.org, michaelpg+watch-md-ui_chromium.org, dbeam+watch-settings_chromium.org, stevenjb+watch-md-settings_chromium.org, arv+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

MD Settings: Update Autofill Credit Card Dialog to accept Enter Key 1) Updates the credit card dialog to accept the Enter key on the name and CC number fields, just as the Options dialog allows. 2) Also controls the Save button state to prohibit saving of blank cards, just like the Options dialog. BUG=622816 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation Review-Url: https://codereview.chromium.org/2654553004 Cr-Commit-Position: refs/heads/master@{#445832} Committed: https://chromium.googlesource.com/chromium/src/+/7be13603d26805f7502868b60df51767f2ae21a9

Patch Set 1 #

Patch Set 2 : update tests #

Unified diffs Side-by-side diffs Delta from patch set Stats (+45 lines, -20 lines) Patch
M chrome/browser/resources/settings/passwords_and_forms_page/credit_card_edit_dialog.html View 3 chunks +14 lines, -6 lines 0 comments Download
M chrome/browser/resources/settings/passwords_and_forms_page/credit_card_edit_dialog.js View 3 chunks +17 lines, -0 lines 0 comments Download
M chrome/test/data/webui/settings/settings_autofill_section_browsertest.js View 1 2 chunks +14 lines, -14 lines 0 comments Download

Messages

Total messages: 19 (14 generated)
tommycli
hcarmona: PTAL, thanks!
3 years, 11 months ago (2017-01-24 00:35:06 UTC) #4
tommycli
hcarmona: PTAL again, thanks!
3 years, 11 months ago (2017-01-24 21:33:17 UTC) #13
hcarmona
lgtm
3 years, 11 months ago (2017-01-24 21:49:35 UTC) #14
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2654553004/20001
3 years, 11 months ago (2017-01-24 21:57:26 UTC) #16
commit-bot: I haz the power
3 years, 11 months ago (2017-01-24 22:07:20 UTC) #19
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/7be13603d26805f7502868b60df5...

Powered by Google App Engine
This is Rietveld 408576698