Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(15)

Issue 2654553003: Handle renaming of mocked methods that are not virtual. (Closed)

Created:
3 years, 11 months ago by Łukasz Anforowicz
Modified:
3 years, 11 months ago
Reviewers:
danakj, dcheng
CC:
chromium-reviews
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Handle renaming of mocked methods that are not virtual. BUG=677544 Review-Url: https://codereview.chromium.org/2654553003 Cr-Commit-Position: refs/heads/master@{#445484} Committed: https://chromium.googlesource.com/chromium/src/+/b420e30cbfb04c5eebf6e9be6835ca89ad21e86e

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+36 lines, -3 lines) Patch
M tools/clang/rewrite_to_chrome_style/RewriteToChromeStyle.cpp View 1 chunk +0 lines, -3 lines 0 comments Download
M tools/clang/rewrite_to_chrome_style/tests/gmock-expected.cc View 2 chunks +18 lines, -0 lines 0 comments Download
M tools/clang/rewrite_to_chrome_style/tests/gmock-original.cc View 2 chunks +18 lines, -0 lines 0 comments Download

Messages

Total messages: 10 (5 generated)
Łukasz Anforowicz
Daniel, can you PTAL?
3 years, 11 months ago (2017-01-23 20:13:39 UTC) #2
danakj
LGTM
3 years, 11 months ago (2017-01-23 20:50:01 UTC) #4
Łukasz Anforowicz
Thanks!
3 years, 11 months ago (2017-01-23 20:57:34 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2654553003/1
3 years, 11 months ago (2017-01-23 20:58:07 UTC) #7
commit-bot: I haz the power
3 years, 11 months ago (2017-01-23 21:11:19 UTC) #10
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/b420e30cbfb04c5eebf6e9be6835...

Powered by Google App Engine
This is Rietveld 408576698