Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(19)

Issue 2654503002: Revert of Mark UrlManagerTest#testAddUrlGarbageCollectsForSize flaky (Closed)

Created:
3 years, 11 months ago by sebsg
Modified:
3 years, 11 months ago
Reviewers:
johnme, nyquist, cco3
CC:
chromium-reviews
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of Mark UrlManagerTest#testAddUrlGarbageCollectsForSize flaky (patchset #1 id:1 of https://codereview.chromium.org/2652703002/ ) Reason for revert: Broke the tree on android, ";" https://build.chromium.org/p/chromium.linux/builders/Android%20Builder%20%28dbg%29/builds/116851 Original issue's description: > Mark UrlManagerTest#testAddUrlGarbageCollectsForSize flaky > > BUG=683923 > TBR=cco3@chromium.org,nyquist@chromium.org > NOTRY=true > > Review-Url: https://codereview.chromium.org/2652703002 > Cr-Commit-Position: refs/heads/master@{#445382} > Committed: https://chromium.googlesource.com/chromium/src/+/1079d8a721465cf5626bfe0f1e4646eaad644829 TBR=cco3@chromium.org,nyquist@chromium.org,johnme@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=683923 Review-Url: https://codereview.chromium.org/2654503002 Cr-Commit-Position: refs/heads/master@{#445383} Committed: https://chromium.googlesource.com/chromium/src/+/b5f5cc79c127005026eb5ee9a9e76b05d4a79d7e

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -6 lines) Patch
M chrome/android/javatests/src/org/chromium/chrome/browser/physicalweb/UrlManagerTest.java View 2 chunks +2 lines, -6 lines 0 comments Download

Messages

Total messages: 6 (3 generated)
sebsg
Created Revert of Mark UrlManagerTest#testAddUrlGarbageCollectsForSize flaky
3 years, 11 months ago (2017-01-23 16:11:41 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2654503002/1
3 years, 11 months ago (2017-01-23 16:11:52 UTC) #3
commit-bot: I haz the power
3 years, 11 months ago (2017-01-23 16:13:09 UTC) #6
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/b5f5cc79c127005026eb5ee9a9e7...

Powered by Google App Engine
This is Rietveld 408576698