[DevTools] Provide a way to delete Indexed DBs

[DevTools] Provide a way to delete Indexed DBs

BUG=682425
Review-Url: https://codereview.chromium.org/2654483004
Cr-Commit-Position: refs/heads/master@{#446147}
Committed: https://chromium.googlesource.com/chromium/src/+/dcca6cc86709771f3d79f093380847d7bf890d5c

[eostroukhov, 2017-01-24 20:16:39]

The CQ bit was checked by eostroukhov@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-01-24 20:17:22]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[eostroukhov, 2017-01-24 20:17:41]

eostroukhov@chromium.org changed reviewers:
+ dgozman@chromium.org, pfeldman@chromium.org

[eostroukhov, 2017-01-24 20:17:42]

Please take a look.

I added a screenshot to the bug. I consider this an interim UX so I did not want
to put too much effort into it.

[commit-bot: I haz the power, 2017-01-24 20:42:05]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-01-24 20:42:07]

Dry run: Try jobs failed on following builders:
  android_arm64_dbg_recipe on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/android_arm6...)

[eostroukhov, 2017-01-24 22:49:44]

The CQ bit was checked by eostroukhov@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-01-24 22:50:40]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[pfeldman, 2017-01-24 23:14:21]

native code looks good.

https://codereview.chromium.org/2654483004/diff/1/third_party/WebKit/Source/c...
File third_party/WebKit/Source/core/inspector/inspector_protocol_config.json
(right):

https://codereview.chromium.org/2654483004/diff/1/third_party/WebKit/Source/c...
third_party/WebKit/Source/core/inspector/inspector_protocol_config.json:1: 
revert blank line

https://codereview.chromium.org/2654483004/diff/1/third_party/WebKit/Source/d...
File third_party/WebKit/Source/devtools/front_end/resources/IndexedDBViews.js
(right):

https://codereview.chromium.org/2654483004/diff/1/third_party/WebKit/Source/d...
third_party/WebKit/Source/devtools/front_end/resources/IndexedDBViews.js:45:
this._reportView.registerRequiredCSS('resources/indexedDBViews.css');
You should not be mixing alien styles into report view, only bring what you need
(if anything).

https://codereview.chromium.org/2654483004/diff/1/third_party/WebKit/Source/d...
third_party/WebKit/Source/devtools/front_end/resources/IndexedDBViews.js:54:
this._clearButton = UI.createTextButton(
This looks more like a UI.List control to me, but that is fine for now.

https://codereview.chromium.org/2654483004/diff/1/third_party/WebKit/Source/d...
third_party/WebKit/Source/devtools/front_end/resources/IndexedDBViews.js:87: if
(confirm(Common.UIString(
Don't use native confirm, use software dialog instead.

https://codereview.chromium.org/2654483004/diff/1/third_party/WebKit/Source/d...
File third_party/WebKit/Source/devtools/front_end/resources/indexedDBViews.css
(right):

https://codereview.chromium.org/2654483004/diff/1/third_party/WebKit/Source/d...
third_party/WebKit/Source/devtools/front_end/resources/indexedDBViews.css:36:
.report-row {
Don't override report view, it'll be hard to refactor it in the future.

[commit-bot: I haz the power, 2017-01-25 01:51:09]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-01-25 01:51:10]

Dry run: Try jobs failed on following builders:
  linux_chromium_rel_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[eostroukhov, 2017-01-25 19:37:55]

The CQ bit was checked by eostroukhov@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-01-25 19:38:31]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[eostroukhov, 2017-01-25 19:54:15]

The CQ bit was checked by eostroukhov@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-01-25 19:54:48]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[eostroukhov, 2017-01-25 19:56:36]

Thanks for the review. I addressed the comments - please take another look.

https://codereview.chromium.org/2654483004/diff/1/third_party/WebKit/Source/c...
File third_party/WebKit/Source/core/inspector/inspector_protocol_config.json
(right):

https://codereview.chromium.org/2654483004/diff/1/third_party/WebKit/Source/c...
third_party/WebKit/Source/core/inspector/inspector_protocol_config.json:1: 
On 2017/01/24 23:14:21, pfeldman wrote:
> revert blank line

Done.

https://codereview.chromium.org/2654483004/diff/1/third_party/WebKit/Source/d...
File third_party/WebKit/Source/devtools/front_end/resources/IndexedDBViews.js
(right):

https://codereview.chromium.org/2654483004/diff/1/third_party/WebKit/Source/d...
third_party/WebKit/Source/devtools/front_end/resources/IndexedDBViews.js:45:
this._reportView.registerRequiredCSS('resources/indexedDBViews.css');
On 2017/01/24 23:14:21, pfeldman wrote:
> You should not be mixing alien styles into report view, only bring what you
need
> (if anything).

Turns out, there's no need for custom styling - reverted.

https://codereview.chromium.org/2654483004/diff/1/third_party/WebKit/Source/d...
third_party/WebKit/Source/devtools/front_end/resources/IndexedDBViews.js:54:
this._clearButton = UI.createTextButton(
On 2017/01/24 23:14:21, pfeldman wrote:
> This looks more like a UI.List control to me, but that is fine for now.

Acknowledged.

https://codereview.chromium.org/2654483004/diff/1/third_party/WebKit/Source/d...
third_party/WebKit/Source/devtools/front_end/resources/IndexedDBViews.js:87: if
(confirm(Common.UIString(
On 2017/01/24 23:14:21, pfeldman wrote:
> Don't use native confirm, use software dialog instead.

Done.

https://codereview.chromium.org/2654483004/diff/1/third_party/WebKit/Source/d...
File third_party/WebKit/Source/devtools/front_end/resources/indexedDBViews.css
(right):

https://codereview.chromium.org/2654483004/diff/1/third_party/WebKit/Source/d...
third_party/WebKit/Source/devtools/front_end/resources/indexedDBViews.css:36:
.report-row {
On 2017/01/24 23:14:21, pfeldman wrote:
> Don't override report view, it'll be hard to refactor it in the future.

No need to override/customize. Removed all unnecessary CSS.

[pfeldman, 2017-01-25 20:02:45]

https://codereview.chromium.org/2654483004/diff/40001/third_party/WebKit/Sour...
File third_party/WebKit/Source/devtools/front_end/resources/IndexedDBViews.js
(right):

https://codereview.chromium.org/2654483004/diff/40001/third_party/WebKit/Sour...
third_party/WebKit/Source/devtools/front_end/resources/IndexedDBViews.js:82:
Resources.ConfirmDialog = class extends UI.VBox {
Mind moving this into UIUtils.js ? UI.ConfirmDialog

https://codereview.chromium.org/2654483004/diff/40001/third_party/WebKit/Sour...
third_party/WebKit/Source/devtools/front_end/resources/IndexedDBViews.js:99: *
@param {!Function} okCb
nit: we just name these "callback"

https://codereview.chromium.org/2654483004/diff/40001/third_party/WebKit/Sour...
third_party/WebKit/Source/devtools/front_end/resources/IndexedDBViews.js:101:
static show(message, okCb) {
move static above the constructor?

https://codereview.chromium.org/2654483004/diff/40001/third_party/WebKit/Sour...
File third_party/WebKit/Source/devtools/front_end/ui/inspectorCommon.css
(right):

https://codereview.chromium.org/2654483004/diff/40001/third_party/WebKit/Sour...
third_party/WebKit/Source/devtools/front_end/ui/inspectorCommon.css:90: /*
position: relative; */
don't land commented code. Also, this is a big change, I hope you don't need it.

[eostroukhov, 2017-01-25 20:18:57]

The CQ bit was checked by eostroukhov@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-01-25 20:19:09]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[eostroukhov, 2017-01-25 20:20:03]

Thanks for the review. Comments addressed. Please, take another look.

https://codereview.chromium.org/2654483004/diff/40001/third_party/WebKit/Sour...
File third_party/WebKit/Source/devtools/front_end/resources/IndexedDBViews.js
(right):

https://codereview.chromium.org/2654483004/diff/40001/third_party/WebKit/Sour...
third_party/WebKit/Source/devtools/front_end/resources/IndexedDBViews.js:82:
Resources.ConfirmDialog = class extends UI.VBox {
On 2017/01/25 20:02:45, pfeldman wrote:
> Mind moving this into UIUtils.js ? UI.ConfirmDialog

Done.

https://codereview.chromium.org/2654483004/diff/40001/third_party/WebKit/Sour...
third_party/WebKit/Source/devtools/front_end/resources/IndexedDBViews.js:99: *
@param {!Function} okCb
On 2017/01/25 20:02:45, pfeldman wrote:
> nit: we just name these "callback"

Done.

https://codereview.chromium.org/2654483004/diff/40001/third_party/WebKit/Sour...
third_party/WebKit/Source/devtools/front_end/resources/IndexedDBViews.js:101:
static show(message, okCb) {
On 2017/01/25 20:02:45, pfeldman wrote:
> move static above the constructor?

Done.

https://codereview.chromium.org/2654483004/diff/40001/third_party/WebKit/Sour...
File third_party/WebKit/Source/devtools/front_end/ui/inspectorCommon.css
(right):

https://codereview.chromium.org/2654483004/diff/40001/third_party/WebKit/Sour...
third_party/WebKit/Source/devtools/front_end/ui/inspectorCommon.css:90: /*
position: relative; */
On 2017/01/25 20:02:45, pfeldman wrote:
> don't land commented code. Also, this is a big change, I hope you don't need
it.

Nice catch! I did this for testing and absolutely don't need to submit it.

[pfeldman, 2017-01-25 21:27:57]

lgtm

[eostroukhov, 2017-01-25 21:34:18]

The CQ bit was unchecked by eostroukhov@chromium.org

[eostroukhov, 2017-01-25 21:34:22]

The CQ bit was checked by eostroukhov@chromium.org

[commit-bot: I haz the power, 2017-01-25 21:34:47]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-01-25 22:53:47]

CQ is committing da patch.

Bot data: {"patchset_id": 60001, "attempt_start_ts": 1485380062792850,
"parent_rev": "a99673a93f2116245e00a6cb66f1a8e2149ed5b3", "commit_rev":
"dcca6cc86709771f3d79f093380847d7bf890d5c"}

[commit-bot: I haz the power, 2017-01-25 22:54:16]

Description was changed from

==========
[DevTools] Provide a way to delete Indexed DBs

BUG=682425
==========

to

==========
[DevTools] Provide a way to delete Indexed DBs

BUG=682425

Review-Url: https://codereview.chromium.org/2654483004
Cr-Commit-Position: refs/heads/master@{#446147}
Committed:
https://chromium.googlesource.com/chromium/src/+/dcca6cc86709771f3d79f0933808...
==========

[commit-bot: I haz the power, 2017-01-25 22:54:18]

Committed patchset #4 (id:60001) as
https://chromium.googlesource.com/chromium/src/+/dcca6cc86709771f3d79f0933808...