Should not gather statistics for a system profile.

Should not gather statistics for a system profile.

If |profile| is not a system profile, this does not imply that |original_profile|
is not a system profile. Gathering statistics should be done only for none
system profile, according to:

DCHECK(!profile_->IsOffTheRecord() && !profile_->IsSystemProfile());
https://cs.chromium.org/chromium/src/chrome/browser/profiles/profile_statistics.cc?q=gatherstati&sq=package:chromium&l=28

BUG=683884
Review-Url: https://codereview.chromium.org/2654443002
Cr-Commit-Position: refs/heads/master@{#445462}
Committed: https://chromium.googlesource.com/chromium/src/+/8595b7aa3cd26aec6af7d4e90fecc0e31c04ea44

[jlebel, 2017-01-23 12:24:13]

jlebel@chromium.org changed reviewers:
+ erg@chromium.org

[jlebel, 2017-01-23 12:24:13]

Hello Elliot,

Can you review this patch? I'm not sure |!profile->IsSystemProfile()| is still
relevant in the if. Should I remove that part of the condition?

Thanks,

[Elliot Glaysher, 2017-01-23 18:35:53]

erg@chromium.org changed reviewers:
+ mlerman@chromium.org

[Elliot Glaysher, 2017-01-23 18:35:54]

I don't know what a system profile is. Adding the original author of system
profiles, who could maybe answer your questions.

[Mike Lerman, 2017-01-23 18:46:50]

On 2017/01/23 18:35:54, Elliot Glaysher wrote:
> I don't know what a system profile is. Adding the original author of system
> profiles, who could maybe answer your questions.

The SystemProfile is what's used for the UserManager, since it needs a profile,
and we didn't want to re-use Guest for this (for reasons I can't recall off the
top of my head).

I'm surprised we ever get a System profile to have a child profile... but maybe
the Dev Tools inspector does weird things. I'd believe it.

This seems like a reasonable addition and will address the issue. LGTM

[Elliot Glaysher, 2017-01-23 18:49:22]

(owners lgtm)

[jlebel, 2017-01-23 18:52:17]

The CQ bit was checked by jlebel@chromium.org

[commit-bot: I haz the power, 2017-01-23 18:52:52]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-01-23 20:20:37]

CQ is committing da patch.

Bot data: {"patchset_id": 1, "attempt_start_ts": 1485197537126530, "parent_rev":
"5342d96f531165d81953c4e39537491dcb7712c8", "commit_rev":
"8595b7aa3cd26aec6af7d4e90fecc0e31c04ea44"}

[commit-bot: I haz the power, 2017-01-23 20:21:12]

Description was changed from

==========
Should not gather statistics for a system profile.

If |profile| is not a system profile, this does not imply that
|original_profile|
is not a system profile. Gathering statistics should be done only for none
system profile, according to:

DCHECK(!profile_->IsOffTheRecord() && !profile_->IsSystemProfile());
https://cs.chromium.org/chromium/src/chrome/browser/profiles/profile_statisti...

BUG=683884
==========

to

==========
Should not gather statistics for a system profile.

If |profile| is not a system profile, this does not imply that
|original_profile|
is not a system profile. Gathering statistics should be done only for none
system profile, according to:

DCHECK(!profile_->IsOffTheRecord() && !profile_->IsSystemProfile());
https://cs.chromium.org/chromium/src/chrome/browser/profiles/profile_statisti...

BUG=683884

Review-Url: https://codereview.chromium.org/2654443002
Cr-Commit-Position: refs/heads/master@{#445462}
Committed:
https://chromium.googlesource.com/chromium/src/+/8595b7aa3cd26aec6af7d4e90fec...
==========

[commit-bot: I haz the power, 2017-01-23 20:21:16]

Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/8595b7aa3cd26aec6af7d4e90fec...