Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(19)

Issue 2654433012: Revert of Show service worker navigation preload requests in DevTools Network tab (Closed)

Created:
3 years, 11 months ago by horo
Modified:
3 years, 11 months ago
Reviewers:
falken, pfeldman
CC:
chromium-reviews, michaeln, mlamouri+watch-content_chromium.org, tzik, jsbell+serviceworker_chromium.org, serviceworker-reviews, jam, nhiroki, blink-reviews-api_chromium.org, haraken, dglazkov+blink, kinuko+serviceworker, horo+watch_chromium.org, blink-reviews, darin-cc_chromium.org, kinuko+watch, shimazu+serviceworker_chromium.org, falken+watch_chromium.org, blink-worker-reviews_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of Show service worker navigation preload requests in DevTools Network tab (patchset #10 id:480001 of https://codereview.chromium.org/2620463002/ ) Reason for revert: Introduced DCHECK crash. BUG=685493 Original issue's description: > Show service worker navigation preload requests in DevTools Network tab. > > Demo: https://youtu.be/I-Qe_Y-xYxE > > Navigation Preload requests are initiated from the browser process. > This is different from the normal network requests which are initiated from the > renderer process. > > When the DevTools show the normal requests in the Network tab, DevTool's > Network events (requestWillBeSent, responseReceived, loadingFinished etc) are > dispatched via InspectorInstrumentation and InspectorNetworkAgent. > > This CL introduces new DevTool's Network events (navigationPreloadSent, > navigationPreloadResponseReceived, navigationPreloadFailed, > navigationPreloadFinished) which are dispatched via InspectorInstrumentation and > InspectorNetworkAgent from ServiceWorkerContextClient. > > In the normal requests case, we record the request sending timestamp when the > renderer process will send the request in InspectorNetworkAgent:: > willSendRequestInternal(). But in the navigation preload case, we record the > timestamp in the browser process, and send it to the service worker's renderer > process using FetchEventPreloadHandle. > > > BUG=649558 > > Review-Url: https://codereview.chromium.org/2620463002 > Cr-Original-Commit-Position: refs/heads/master@{#445630} > Committed: https://chromium.googlesource.com/chromium/src/+/4c6b3b0f11b62e069d9d84ba99dbe94a45a5c622 > Review-Url: https://codereview.chromium.org/2620463002 > Cr-Commit-Position: refs/heads/master@{#445699} > Committed: https://chromium.googlesource.com/chromium/src/+/23276c71698583a0142e8213bada22e3ae8d0a0e TBR=falken@chromium.org,pfeldman@chromium.org # Not skipping CQ checks because original CL landed more than 1 days ago. BUG=649558 Review-Url: https://codereview.chromium.org/2654433012 Cr-Commit-Position: refs/heads/master@{#446270} Committed: https://chromium.googlesource.com/chromium/src/+/16de2c25e724f07d46b68f5758e49fae6f136073

Patch Set 1 #

Patch Set 2 : rebase #

Patch Set 3 : rebase again #

Unified diffs Side-by-side diffs Delta from patch set Stats (+91 lines, -400 lines) Patch
M content/browser/loader/resource_dispatcher_host_impl.cc View 1 1 chunk +1 line, -6 lines 0 comments Download
M content/browser/service_worker/service_worker_browsertest.cc View 1 1 chunk +2 lines, -2 lines 0 comments Download
M content/browser/service_worker/service_worker_fetch_dispatcher.cc View 1 1 chunk +0 lines, -2 lines 0 comments Download
M content/renderer/service_worker/service_worker_context_client.h View 1 1 chunk +1 line, -2 lines 0 comments Download
M content/renderer/service_worker/service_worker_context_client.cc View 1 5 chunks +9 lines, -13 lines 0 comments Download
M third_party/WebKit/LayoutTests/http/tests/inspector/inspector-test.js View 1 1 chunk +2 lines, -2 lines 0 comments Download
D third_party/WebKit/LayoutTests/http/tests/inspector/service-workers/resources/navigation-preload-scope.php View 1 chunk +0 lines, -13 lines 0 comments Download
D third_party/WebKit/LayoutTests/http/tests/inspector/service-workers/resources/navigation-preload-worker.php View 1 chunk +0 lines, -29 lines 0 comments Download
D third_party/WebKit/LayoutTests/http/tests/inspector/service-workers/service-workers-navigation-preload.html View 1 chunk +0 lines, -130 lines 0 comments Download
D third_party/WebKit/LayoutTests/http/tests/inspector/service-workers/service-workers-navigation-preload-expected.txt View 1 chunk +0 lines, -29 lines 0 comments Download
M third_party/WebKit/Source/core/inspector/InspectorInstrumentation.cpp View 1 1 chunk +1 line, -2 lines 0 comments Download
M third_party/WebKit/Source/core/inspector/InspectorInstrumentation.idl View 1 1 chunk +5 lines, -5 lines 0 comments Download
M third_party/WebKit/Source/core/inspector/InspectorNetworkAgent.h View 1 3 chunks +8 lines, -6 lines 0 comments Download
M third_party/WebKit/Source/core/inspector/InspectorNetworkAgent.cpp View 1 2 11 chunks +26 lines, -44 lines 0 comments Download
M third_party/WebKit/Source/core/inspector/WorkerInspectorController.h View 1 3 chunks +2 lines, -6 lines 0 comments Download
M third_party/WebKit/Source/core/inspector/WorkerInspectorController.cpp View 1 3 chunks +4 lines, -12 lines 0 comments Download
M third_party/WebKit/Source/core/inspector/browser_protocol.json View 1 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/loader/DocumentThreadableLoader.cpp View 1 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/loader/FrameFetchContext.cpp View 1 4 chunks +5 lines, -6 lines 0 comments Download
M third_party/WebKit/Source/core/loader/PingLoader.cpp View 1 2 chunks +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/core/workers/DedicatedWorkerTest.cpp View 1 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/workers/InProcessWorkerMessagingProxy.cpp View 1 1 chunk +1 line, -2 lines 0 comments Download
M third_party/WebKit/Source/core/workers/ThreadedWorkletMessagingProxy.cpp View 1 1 chunk +1 line, -2 lines 0 comments Download
M third_party/WebKit/Source/core/workers/ThreadedWorkletTest.cpp View 1 1 chunk +1 line, -2 lines 0 comments Download
M third_party/WebKit/Source/core/workers/WorkerThread.cpp View 1 2 2 chunks +1 line, -3 lines 0 comments Download
M third_party/WebKit/Source/core/workers/WorkerThreadStartupData.h View 1 3 chunks +3 lines, -8 lines 0 comments Download
M third_party/WebKit/Source/core/workers/WorkerThreadStartupData.cpp View 1 2 chunks +2 lines, -4 lines 0 comments Download
M third_party/WebKit/Source/core/workers/WorkerThreadTest.cpp View 1 1 chunk +1 line, -2 lines 0 comments Download
M third_party/WebKit/Source/core/workers/WorkerThreadTestHelper.h View 1 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/devtools/front_end/network/NetworkDataGridNode.js View 1 2 1 chunk +0 lines, -6 lines 0 comments Download
M third_party/WebKit/Source/devtools/front_end/sdk/NetworkLog.js View 1 1 chunk +0 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/devtools/front_end/sdk/NetworkRequest.js View 1 1 chunk +1 line, -2 lines 0 comments Download
M third_party/WebKit/Source/devtools/front_end/sdk/SubTargetsManager.js View 1 2 chunks +3 lines, -10 lines 0 comments Download
M third_party/WebKit/Source/modules/compositorworker/AnimationWorkletThreadTest.cpp View 1 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/modules/compositorworker/CompositorWorkerThreadTest.cpp View 1 1 chunk +1 line, -2 lines 0 comments Download
M third_party/WebKit/Source/modules/webaudio/AudioWorkletThreadTest.cpp View 1 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/web/ServiceWorkerGlobalScopeProxy.h View 1 2 chunks +0 lines, -3 lines 0 comments Download
M third_party/WebKit/Source/web/ServiceWorkerGlobalScopeProxy.cpp View 1 6 chunks +0 lines, -27 lines 0 comments Download
M third_party/WebKit/Source/web/WebEmbeddedWorkerImpl.cpp View 1 2 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/web/WebSharedWorkerImpl.cpp View 1 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/public/web/modules/serviceworker/WebServiceWorkerContextProxy.h View 1 3 chunks +0 lines, -6 lines 0 comments Download

Messages

Total messages: 23 (14 generated)
horo
Created Revert of Show service worker navigation preload requests in DevTools Network tab
3 years, 11 months ago (2017-01-26 03:45:58 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2654433012/1
3 years, 11 months ago (2017-01-26 03:46:45 UTC) #3
commit-bot: I haz the power
Try jobs failed on following builders: ios-device-xcode-clang on master.tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-device-xcode-clang/builds/27976) ios-simulator on master.tryserver.chromium.mac (JOB_FAILED, ...
3 years, 11 months ago (2017-01-26 03:50:01 UTC) #5
horo
I understood the crash reason. I want to land the fix patch instead of reverting. ...
3 years, 11 months ago (2017-01-26 04:59:06 UTC) #12
horo
On 2017/01/26 04:59:06, horo wrote: > I understood the crash reason. > I want to ...
3 years, 11 months ago (2017-01-26 05:50:54 UTC) #14
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2654433012/310001
3 years, 11 months ago (2017-01-26 05:52:05 UTC) #16
commit-bot: I haz the power
Try jobs failed on following builders: ios-simulator on master.tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-simulator/builds/144151) ios-simulator-xcode-clang on master.tryserver.chromium.mac (JOB_FAILED, ...
3 years, 11 months ago (2017-01-26 05:54:13 UTC) #18
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2654433012/330001
3 years, 11 months ago (2017-01-26 05:59:45 UTC) #20
commit-bot: I haz the power
3 years, 11 months ago (2017-01-26 07:50:30 UTC) #23
Message was sent while issue was closed.
Committed patchset #3 (id:330001) as
https://chromium.googlesource.com/chromium/src/+/16de2c25e724f07d46b68f5758e4...

Powered by Google App Engine
This is Rietveld 408576698