Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(8)

Issue 2654433011: MD Settings: Display: Fix selected display update (Closed)

Created:
3 years, 11 months ago by stevenjb
Modified:
3 years, 10 months ago
Reviewers:
malaykeshav
CC:
arv+watch_chromium.org, chromium-reviews, dbeam+watch-settings_chromium.org, michaelpg+watch-md-settings_chromium.org, michaelpg+watch-md-ui_chromium.org, stevenjb+watch-md-settings_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

MD Settings: Display: Fix selected display update BUG=682348, 661807 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation Review-Url: https://codereview.chromium.org/2654433011 Cr-Commit-Position: refs/heads/master@{#446429} Committed: https://chromium.googlesource.com/chromium/src/+/3e35aa93c9a23b954e522f463178188cc80e2ce0

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+7 lines, -2 lines) Patch
M chrome/browser/resources/settings/device_page/display.js View 1 chunk +7 lines, -2 lines 0 comments Download

Messages

Total messages: 15 (8 generated)
stevenjb
3 years, 11 months ago (2017-01-25 22:04:46 UTC) #3
malaykeshav
lgtm
3 years, 11 months ago (2017-01-25 22:21:45 UTC) #5
malaykeshav
On 2017/01/25 at 22:21:45, malaykeshav wrote: > lgtm Adding crbug/661807 to this as well.
3 years, 11 months ago (2017-01-25 22:22:42 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2654433011/1
3 years, 11 months ago (2017-01-25 22:26:26 UTC) #8
commit-bot: I haz the power
Try jobs failed on following builders: mac_chromium_compile_dbg_ng on master.tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_compile_dbg_ng/builds/344401)
3 years, 11 months ago (2017-01-25 22:40:41 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2654433011/1
3 years, 10 months ago (2017-01-26 19:36:24 UTC) #12
commit-bot: I haz the power
3 years, 10 months ago (2017-01-26 20:26:20 UTC) #15
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/3e35aa93c9a23b954e522f463178...

Powered by Google App Engine
This is Rietveld 408576698