Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(343)

Issue 2654433008: Remove logic to add CQ_EXTRA_TRYBOTS on benchmark changes. (Closed)

Created:
3 years, 11 months ago by shatch
Modified:
3 years, 11 months ago
Reviewers:
dtu
CC:
chromium-reviews, telemetry-reviews_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

These don't have any ability to specify the exact benchmarks we want to run, and often take hours to come back since the bots are overloaded and running way too many benchmarks. Additionally, Pinpoint won't support these kind of trybots since it won't exist as a bot on the waterfall. Going forward, reviewers will simply request perf try job results be linked in reviews. BUG=683336 Review-Url: https://codereview.chromium.org/2654433008 Cr-Commit-Position: refs/heads/master@{#445906} Committed: https://chromium.googlesource.com/chromium/src/+/d02596e4e33a888672800f6eb27588760191b476

Patch Set 1 #

Patch Set 2 : Modify benchmark to test. #

Patch Set 3 : Undo benchmark change. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -48 lines) Patch
M tools/perf/PRESUBMIT.py View 2 chunks +0 lines, -48 lines 0 comments Download

Messages

Total messages: 16 (10 generated)
shatch
3 years, 11 months ago (2017-01-24 21:21:02 UTC) #6
dtu
lgtm
3 years, 11 months ago (2017-01-24 22:39:29 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2654433008/40001
3 years, 11 months ago (2017-01-24 22:40:05 UTC) #9
commit-bot: I haz the power
Try jobs failed on following builders: android_n5x_swarming_rel on master.tryserver.chromium.android (JOB_FAILED, https://build.chromium.org/p/tryserver.chromium.android/builders/android_n5x_swarming_rel/builds/106248) linux_android_rel_ng on master.tryserver.chromium.android (JOB_FAILED, ...
3 years, 11 months ago (2017-01-24 23:36:16 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2654433008/40001
3 years, 11 months ago (2017-01-25 00:05:49 UTC) #13
commit-bot: I haz the power
3 years, 11 months ago (2017-01-25 01:44:39 UTC) #16
Message was sent while issue was closed.
Committed patchset #3 (id:40001) as
https://chromium.googlesource.com/chromium/src/+/d02596e4e33a888672800f6eb275...

Powered by Google App Engine
This is Rietveld 408576698