Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(359)

Issue 2654433003: [regexp] Fix StringCharacterPosition for ThinStrings (Closed)

Created:
3 years, 11 months ago by Jakob Kummerow
Modified:
3 years, 11 months ago
Reviewers:
Yang
CC:
v8-reviews_googlegroups.com
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[regexp] Fix StringCharacterPosition for ThinStrings BUG=chromium:683515 Review-Url: https://codereview.chromium.org/2654433003 Cr-Commit-Position: refs/heads/master@{#42605} Committed: https://chromium.googlesource.com/v8/v8/+/a962247b5b09f54976f93fb2f6187f99ff43e631

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -1 line) Patch
M src/regexp/regexp-macro-assembler.cc View 2 chunks +3 lines, -1 line 0 comments Download

Messages

Total messages: 8 (4 generated)
Jakob Kummerow
PTAL.
3 years, 11 months ago (2017-01-23 15:52:23 UTC) #2
Yang
On 2017/01/23 15:52:23, Jakob Kummerow wrote: > PTAL. lgtm
3 years, 11 months ago (2017-01-23 15:53:20 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2654433003/1
3 years, 11 months ago (2017-01-23 15:53:59 UTC) #5
commit-bot: I haz the power
3 years, 11 months ago (2017-01-23 16:27:41 UTC) #8
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/v8/v8/+/a962247b5b09f54976f93fb2f6187f99ff4...

Powered by Google App Engine
This is Rietveld 408576698