Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(33)

Issue 2654433002: Cache delegate_->IsNested() in TaskQueueManager::DoWork (Closed)

Created:
3 years, 11 months ago by alex clarke (OOO till 29th)
Modified:
3 years, 11 months ago
Reviewers:
altimin
CC:
chromium-reviews, blink-reviews, kinuko+watch, scheduler-bugs_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Cache delegate_->IsNested() in TaskQueueManager::DoWork As far as a DoWork is concerned the value of delegate_->IsNested() is constant (ProcessTaskFromWorkQueue can run a nested loop but it must have exited before it finished). BUG=578176 Review-Url: https://codereview.chromium.org/2654433002 Cr-Commit-Position: refs/heads/master@{#445384} Committed: https://chromium.googlesource.com/chromium/src/+/b8e56c6b6d507d27a49f68db8e1034ed9e409887

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+8 lines, -4 lines) Patch
M third_party/WebKit/Source/platform/scheduler/base/task_queue_manager.h View 1 chunk +1 line, -0 lines 0 comments Download
M third_party/WebKit/Source/platform/scheduler/base/task_queue_manager.cc View 5 chunks +7 lines, -4 lines 0 comments Download

Messages

Total messages: 12 (8 generated)
alex clarke (OOO till 29th)
3 years, 11 months ago (2017-01-23 12:12:56 UTC) #3
altimin
lgtm
3 years, 11 months ago (2017-01-23 12:26:32 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2654433002/1
3 years, 11 months ago (2017-01-23 15:13:33 UTC) #9
commit-bot: I haz the power
3 years, 11 months ago (2017-01-23 16:14:36 UTC) #12
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/b8e56c6b6d507d27a49f68db8e10...

Powered by Google App Engine
This is Rietveld 408576698