Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(229)

Issue 2654423002: MD Settings: Redirect chrome://chrome to MD About when MD Settings is on (Closed)

Created:
3 years, 11 months ago by tommycli
Modified:
3 years, 11 months ago
Reviewers:
sky
CC:
chromium-reviews
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

MD Settings: Redirect chrome://chrome to MD About when MD Settings is on BUG=638722 Review-Url: https://codereview.chromium.org/2654423002 Cr-Commit-Position: refs/heads/master@{#446525} Committed: https://chromium.googlesource.com/chromium/src/+/a4aed8758b516fb6b3e84a93ba7b303347415715

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -0 lines) Patch
M chrome/browser/browser_about_handler.cc View 1 chunk +6 lines, -0 lines 0 comments Download

Messages

Total messages: 9 (4 generated)
tommycli
sky: PTAL, thanks!
3 years, 11 months ago (2017-01-26 23:26:22 UTC) #2
sky
LGTM
3 years, 11 months ago (2017-01-26 23:35:29 UTC) #3
tommycli
On 2017/01/26 23:35:29, sky wrote: > LGTM thanks!
3 years, 11 months ago (2017-01-26 23:37:30 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2654423002/1
3 years, 11 months ago (2017-01-26 23:38:58 UTC) #6
commit-bot: I haz the power
3 years, 11 months ago (2017-01-27 01:36:00 UTC) #9
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/a4aed8758b516fb6b3e84a93ba7b...

Powered by Google App Engine
This is Rietveld 408576698