Added api_methods flag to CSSProperties.json5.

third_party/WebKit/Source/core/css/CSSProperties.json5

Index: third_party/WebKit/Source/core/css/CSSProperties.json5
diff --git a/third_party/WebKit/Source/core/css/CSSProperties.json5 b/third_party/WebKit/Source/core/css/CSSProperties.json5
index 1e8820da2aa7e7ff34af3f2bce82d2fb48096deb..6a46fb8bd35a448432af41f7a0a2513d59f4a88a 100644
--- a/third_party/WebKit/Source/core/css/CSSProperties.json5
+++ b/third_party/WebKit/Source/core/css/CSSProperties.json5
@@ -31,7 +31,7 @@
 
     // - api_class: true|"classname"
     // Specifies the existance (and optionally name) of a CSSPropertyAPI
-    // implementation for the property to be used by make_css_property_descriptor.py.
+    // implementation for the property to be used by make_css_property_apis.py.
     // See core/css/properties/CSSPropertyAPI.h for API details.
     // * Add this flag if the API has been implemented for this property.
     // * If the classname for this is different to the name of the property, specify a
@@ -42,6 +42,17 @@
     api_class: {
     },
 
+    // - api_methods: ["method1", "method2"]
+    // List of methods that are implemented in the CSSPropertyAPI for this property.
+    // This is used by make_css_property_apis.py to specify which functions are defined
+    // in the .h file for this property, and also used in CSSPropertyAPIFiles.h.tmpl to
+    // generate declarations for only the methods this property has implementations for.
+    api_methods: {
+      default: [],
+      valid_type: "list",
+      valid_values: [["parseSingleValue"]],

[sashab, 2017/01/31 22:50:58]

Is this right? I think with https://codereview.chromium.org/2666173002 you won't
need the double braces :)

Maybe let ktyliu land first and rebase over his change :)

[aazzam, 2017/01/31 22:55:43]

Yeah fixed for kevins change :)

[ktyliu, 2017/01/31 23:02:46]

committing my change now
also feel free to use  [["parseSingleValue"]] for now if you want to commit
immediately, since you'll have to modify this and add more methods very soon :)

+    },
+
     // - keyword_only
     // These properties only store keyword values. This is used when
     // generating the ComputedStyle storage for the property. The initial
@@ -352,6 +363,7 @@
     {
       name: "font-size-adjust",
       api_class: true,
+      api_methods: ["parseSingleValue"],
       converter: "convertFontSizeAdjust",
       font: true,
       inherited: true,
@@ -379,6 +391,7 @@
     {
       name: "font-variant-ligatures",
       api_class: true,
+      api_methods: ["parseSingleValue"],
       converter: "convertFontVariantLigatures",
       font: true,
       inherited: true,
@@ -389,6 +402,7 @@
     {
       name: "font-variant-caps",
       api_class: true,
+      api_methods: ["parseSingleValue"],
       converter: "convertFontVariantCaps",
       font: true,
       inherited: true,
@@ -398,6 +412,7 @@
     {
       name: "font-variant-numeric",
       api_class: true,
+      api_methods: ["parseSingleValue"],
       converter: "convertFontVariantNumeric",
       font: true,
       inherited: true,
@@ -425,6 +440,7 @@
     {
       name: "font-variation-settings",
       api_class: true,
+      api_methods: ["parseSingleValue"],
       converter: "convertFontVariationSettings",
       font: true,
       inherited: true,
@@ -488,6 +504,7 @@
     {
       name: "zoom",
       api_class: true,
+      api_methods: ["parseSingleValue"],
       custom_all: true,
       priority: "High",
     },
@@ -584,6 +601,7 @@
     {
       name: "border-bottom-left-radius",
       api_class: "CSSPropertyAPIBorderRadius",
+      api_methods: ["parseSingleValue"],
       converter: "convertRadius",
       initial: "initialBorderRadius",
       interpolable: true,
@@ -591,6 +609,7 @@
     {
       name: "border-bottom-right-radius",
       api_class: "CSSPropertyAPIBorderRadius",
+      api_methods: ["parseSingleValue"],
       converter: "convertRadius",
       initial: "initialBorderRadius",
       interpolable: true,
@@ -631,6 +650,7 @@
     {
       name: "border-image-source",
       api_class: "CSSPropertyAPIImage",
+      api_methods: ["parseSingleValue"],
       custom_value: true,
       interpolable: true,
       keywords: ["none"],
@@ -681,6 +701,7 @@
     {
       name: "border-top-left-radius",
       api_class: "CSSPropertyAPIBorderRadius",
+      api_methods: ["parseSingleValue"],
       converter: "convertRadius",
       initial: "initialBorderRadius",
       interpolable: true,
@@ -688,6 +709,7 @@
     {
       name: "border-top-right-radius",
       api_class: "CSSPropertyAPIBorderRadius",
+      api_methods: ["parseSingleValue"],
       converter: "convertRadius",
       initial: "initialBorderRadius",
       interpolable: true,
@@ -748,6 +770,7 @@
     {
       name: "caret-color",
       api_class: true,
+      api_methods: ["parseSingleValue"],
       custom_all: true,
       inherited: true,
       interpolable: true,
@@ -756,6 +779,7 @@
     {
       name: "clip",
       api_class: true,
+      api_methods: ["parseSingleValue"],
       converter: "convertClip",
       custom_all: true,
       interpolable: true,
@@ -763,6 +787,7 @@
     {
       name: "clip-path",
       api_class: true,
+      api_methods: ["parseSingleValue"],
       converter: "convertClipPath",
       interpolable: true,
     },
@@ -795,12 +820,14 @@
     {
       name: "contain",
       api_class: true,
+      api_methods: ["parseSingleValue"],
       converter: "convertFlags<Containment>",
       runtime_flag: "CSSContainment",
     },
     {
       name: "content",
       api_class: true,
+      api_methods: ["parseSingleValue"],
       custom_all: true,
       repeated: true,
       typedom_types: ["Image"],
@@ -816,6 +843,7 @@
     {
       name: "cursor",
       api_class: true,
+      api_methods: ["parseSingleValue"],
       custom_all: true,
       inherited: true,
     },
@@ -855,6 +883,7 @@
     {
       name: "fill",
       api_class: "CSSPropertyAPIPaintStroke",
+      api_methods: ["parseSingleValue"],
       custom_all: true,
       inherited: true,
       interpolable: true,
@@ -864,6 +893,7 @@
     {
       name: "fill-opacity",
       api_class: "CSSPropertyAPIOpacity",
+      api_methods: ["parseSingleValue"],
       converter: "convertNumberOrPercentage",
       inherited: true,
       interpolable: true,
@@ -883,6 +913,7 @@
     {
       name: "flex-basis",
       api_class: true,
+      api_methods: ["parseSingleValue"],
       converter: "convertLengthOrAuto",
       interpolable: true,
     },
@@ -909,6 +940,7 @@
     {
       name: "flood-color",
       api_class: "CSSPropertyAPIColor",
+      api_methods: ["parseSingleValue"],
       converter: "convertColor",
       interpolable: true,
       svg: true,
@@ -916,6 +948,7 @@
     {
       name: "flood-opacity",
       api_class: "CSSPropertyAPIOpacity",
+      api_methods: ["parseSingleValue"],
       converter: "convertNumberOrPercentage",
       interpolable: true,
       svg: true,
@@ -928,6 +961,7 @@
     {
       name: "grid-auto-flow",
       api_class: true,
+      api_methods: ["parseSingleValue"],
       converter: "convertGridAutoFlow",
       runtime_flag: "CSSGridLayout",
       type_name: "GridAutoFlow",
@@ -1004,6 +1038,7 @@
     {
       name: "image-orientation",
       api_class: true,
+      api_methods: ["parseSingleValue"],
       converter: "convertImageOrientation",
       inherited: true,
       name_for_methods: "RespectImageOrientation",
@@ -1039,6 +1074,7 @@
     {
       name: "letter-spacing",
       api_class: "CSSPropertyAPILetterAndWordSpacing",
+      api_methods: ["parseSingleValue"],
       converter: "convertSpacing",
       inherited: true,
       initial: "initialLetterWordSpacing",
@@ -1047,6 +1083,7 @@
     {
       name: "lighting-color",
       api_class: "CSSPropertyAPIColor",
+      api_methods: ["parseSingleValue"],
       converter: "convertColor",
       interpolable: true,
       svg: true,
@@ -1061,6 +1098,7 @@
     {
       name: "list-style-image",
       api_class: "CSSPropertyAPIImage",
+      api_methods: ["parseSingleValue"],
       custom_value: true,
       inherited: true,
       interpolable: true,
@@ -1211,6 +1249,7 @@
     {
       name: "offset-position",
       api_class: true,
+      api_methods: ["parseSingleValue"],
       converter: "convertPositionOrAuto",
       interpolable: true,
       runtime_flag: "CSSOffsetPositionAnchor",
@@ -1230,12 +1269,14 @@
     {
       name: "opacity",
       api_class: "CSSPropertyAPIOpacity",
+      api_methods: ["parseSingleValue"],
       interpolable: true,
       type_name: "float",
     },
     {
       name: "order",
       api_class: true,
+      api_methods: ["parseSingleValue"],
       type_name: "int",
     },
     {
@@ -1247,12 +1288,14 @@
     {
       name: "outline-color",
       api_class: true,
+      api_methods: ["parseSingleValue"],
       custom_all: true,
       interpolable: true,
     },
     {
       name: "outline-offset",
       api_class: true,
+      api_methods: ["parseSingleValue"],
       converter: "convertComputedLength<int>",
       interpolable: true,
     },
@@ -1263,6 +1306,7 @@
     {
       name: "outline-width",
       api_class: true,
+      api_methods: ["parseSingleValue"],
       converter: "convertLineWidth<unsigned short>",
       interpolable: true,
     },
@@ -1286,6 +1330,7 @@
     {
       name: "padding-bottom",
       api_class: "CSSPropertyAPIPadding",
+      api_methods: ["parseSingleValue"],
       converter: "convertLength",
       initial: "initialPadding",
       interpolable: true,
@@ -1293,6 +1338,7 @@
     {
       name: "padding-left",
       api_class: "CSSPropertyAPIPadding",
+      api_methods: ["parseSingleValue"],
       converter: "convertLength",
       initial: "initialPadding",
       interpolable: true,
@@ -1300,6 +1346,7 @@
     {
       name: "padding-right",
       api_class: "CSSPropertyAPIPadding",
+      api_methods: ["parseSingleValue"],
       converter: "convertLength",
       initial: "initialPadding",
       interpolable: true,
@@ -1307,6 +1354,7 @@
     {
       name: "padding-top",
       api_class: "CSSPropertyAPIPadding",
+      api_methods: ["parseSingleValue"],
       converter: "convertLength",
       initial: "initialPadding",
       interpolable: true,
@@ -1314,6 +1362,7 @@
     {
       name: "paint-order",
       api_class: true,
+      api_methods: ["parseSingleValue"],
       converter: "convertPaintOrder",
       inherited: true,
       svg: true,
@@ -1345,6 +1394,7 @@
     {
       name: "quotes",
       api_class: true,
+      api_methods: ["parseSingleValue"],
       converter: "convertQuotes",
       inherited: true,
     },
@@ -1370,6 +1420,7 @@
     {
       name: "rx",
       api_class: "CSSPropertyAPIRadius",
+      api_methods: ["parseSingleValue"],
       converter: "convertLengthOrAuto",
       interpolable: true,
       svg: true,
@@ -1377,6 +1428,7 @@
     {
       name: "ry",
       api_class: "CSSPropertyAPIRadius",
+      api_methods: ["parseSingleValue"],
       converter: "convertLengthOrAuto",
       interpolable: true,
       svg: true,
@@ -1409,24 +1461,28 @@
     {
       name: "scroll-snap-coordinate",
       api_class: true,
+      api_methods: ["parseSingleValue"],
       converter: "convertSnapCoordinates",
       runtime_flag: "CSSScrollSnapPoints",
     },
     {
       name: "shape-image-threshold",
       api_class: true,
+      api_methods: ["parseSingleValue"],
       interpolable: true,
       type_name: "float",
     },
     {
       name: "shape-margin",
       api_class: true,
+      api_methods: ["parseSingleValue"],
       converter: "convertLength",
       interpolable: true,
     },
     {
       name: "shape-outside",
       api_class: true,
+      api_methods: ["parseSingleValue"],
       converter: "convertShapeValue",
       interpolable: true,
       typedom_types: ["Image"],
@@ -1439,11 +1495,13 @@
     {
       name: "size",
       api_class: true,
+      api_methods: ["parseSingleValue"],
       custom_all: true,
     },
     {
       name: "snap-height",
       api_class: true,
+      api_methods: ["parseSingleValue"],
       custom_all: true,
       inherited: true,
       runtime_flag: "CSSSnapSize",
@@ -1455,6 +1513,7 @@
     {
       name: "stop-color",
       api_class: "CSSPropertyAPIColor",
+      api_methods: ["parseSingleValue"],
       converter: "convertColor",
       interpolable: true,
       svg: true,
@@ -1462,6 +1521,7 @@
     {
       name: "stop-opacity",
       api_class: "CSSPropertyAPIOpacity",
+      api_methods: ["parseSingleValue"],
       converter: "convertNumberOrPercentage",
       interpolable: true,
       svg: true,
@@ -1469,6 +1529,7 @@
     {
       name: "stroke",
       api_class: "CSSPropertyAPIPaintStroke",
+      api_methods: ["parseSingleValue"],
       custom_all: true,
       inherited: true,
       interpolable: true,
@@ -1478,6 +1539,7 @@
     {
       name: "stroke-dasharray",
       api_class: true,
+      api_methods: ["parseSingleValue"],
       converter: "convertStrokeDasharray",
       inherited: true,
       interpolable: true,
@@ -1509,6 +1571,7 @@
     {
       name: "stroke-miterlimit",
       api_class: true,
+      api_methods: ["parseSingleValue"],
       inherited: true,
       interpolable: true,
       name_for_methods: "StrokeMiterLimit",
@@ -1518,6 +1581,7 @@
     {
       name: "stroke-opacity",
       api_class: "CSSPropertyAPIOpacity",
+      api_methods: ["parseSingleValue"],
       converter: "convertNumberOrPercentage",
       inherited: true,
       interpolable: true,
@@ -1534,6 +1598,7 @@
     {
       name: "tab-size",
       api_class: true,
+      api_methods: ["parseSingleValue"],
       converter: "convertLengthOrTabSpaces",
       inherited: true,
       type_name: "TabSize",
@@ -1573,6 +1638,7 @@
     {
       name: "text-decoration-color",
       api_class: true,
+      api_methods: ["parseSingleValue"],
       custom_all: true,
       interpolable: true,
       runtime_flag: "CSS3TextDecorations",
@@ -1587,6 +1653,7 @@
     {
       name: "text-decoration-skip",
       api_class: true,
+      api_methods: ["parseSingleValue"],
       converter: "convertFlags<TextDecorationSkip>",
       inherited: true,
       runtime_flag: "CSS3TextDecorations",
@@ -1600,6 +1667,7 @@
     {
       name: "text-indent",
       api_class: true,
+      api_methods: ["parseSingleValue"],
       custom_all: true,
       inherited: true,
       interpolable: true,
@@ -1623,6 +1691,7 @@
     {
       name: "text-size-adjust",
       api_class: true,
+      api_methods: ["parseSingleValue"],
       converter: "convertTextSizeAdjust",
       inherited: true,
       type_name: "TextSizeAdjust",
@@ -1638,6 +1707,7 @@
     {
       name: "text-underline-position",
       api_class: true,
+      api_methods: ["parseSingleValue"],
       inherited: true,
       runtime_flag: "CSS3TextDecorations",
       type_name: "TextUnderlinePosition",
@@ -1654,6 +1724,7 @@
     {
       name: "touch-action",
       api_class: true,
+      api_methods: ["parseSingleValue"],
       converter: "convertFlags<TouchAction>",
       type_name: "TouchAction",
     },
@@ -1667,6 +1738,7 @@
     {
       name: "transform-origin",
       api_class: true,
+      api_methods: ["parseSingleValue"],
       converter: "convertTransformOrigin",
       interpolable: true,
     },
@@ -1677,6 +1749,7 @@
     {
       name: "translate",
       api_class: true,
+      api_methods: ["parseSingleValue"],
       converter: "convertTranslate",
       interpolable: true,
       runtime_flag: "CSSIndependentTransformProperties",
@@ -1684,6 +1757,7 @@
     {
       name: "rotate",
       api_class: true,
+      api_methods: ["parseSingleValue"],
       converter: "convertRotate",
       interpolable: true,
       runtime_flag: "CSSIndependentTransformProperties",
@@ -1691,6 +1765,7 @@
     {
       name: "scale",
       api_class: true,
+      api_methods: ["parseSingleValue"],
       converter: "convertScale",
       interpolable: true,
       runtime_flag: "CSSIndependentTransformProperties",
@@ -1712,6 +1787,7 @@
     {
       name: "vertical-align",
       api_class: true,
+      api_methods: ["parseSingleValue"],
       custom_inherit: true,
       custom_value: true,
       interpolable: true,
@@ -1792,6 +1868,7 @@
     {
       name: "-webkit-box-flex-group",
       api_class: true,
+      api_methods: ["parseSingleValue"],
       type_name: "unsigned int",
     },
     "-webkit-box-lines",
@@ -1814,6 +1891,7 @@
     {
       name: "column-gap",
       api_class: true,
+      api_methods: ["parseSingleValue"],
       converter: "convertComputedLength<float>",
       custom_all: true,
       interpolable: true,
@@ -1821,6 +1899,7 @@
     {
       name: "column-rule-color",
       api_class: "CSSPropertyAPIColor",
+      api_methods: ["parseSingleValue"],
       custom_all: true,
       interpolable: true,
     },
@@ -1832,12 +1911,14 @@
     {
       name: "column-rule-width",
       api_class: true,
+      api_methods: ["parseSingleValue"],
       converter: "convertLineWidth<unsigned short>",
       interpolable: true,
     },
     {
       name: "column-span",
       api_class: true,
+      api_methods: ["parseSingleValue"],
       type_name: "ColumnSpan",
     },
     {
@@ -1849,6 +1930,7 @@
     {
       name: "-webkit-highlight",
       api_class: true,
+      api_methods: ["parseSingleValue"],
       converter: "convertString<CSSValueNone>",
       inherited: true,
     },
@@ -1866,6 +1948,7 @@
     {
       name: "-webkit-line-clamp",
       api_class: true,
+      api_methods: ["parseSingleValue"],
       type_name: "LineClampValue",
     },
     {
@@ -1903,6 +1986,7 @@
     {
       name: "-webkit-mask-box-image-source",
       api_class: "CSSPropertyAPIImage",
+      api_methods: ["parseSingleValue"],
       custom_value: true,
       interpolable: true,
     },
@@ -1988,6 +2072,7 @@
     {
       name: "-webkit-tap-highlight-color",
       api_class: "CSSPropertyAPIColor",
+      api_methods: ["parseSingleValue"],
       converter: "convertColor",
       inherited: true,
     },
@@ -2000,6 +2085,7 @@
     {
       name: "-webkit-text-emphasis-color",
       api_class: "CSSPropertyAPIColor",
+      api_methods: ["parseSingleValue"],
       custom_all: true,
       inherited: true,
     },
@@ -2011,12 +2097,14 @@
     {
       name: "-webkit-text-emphasis-style",
       api_class: true,
+      api_methods: ["parseSingleValue"],
       custom_all: true,
       inherited: true,
     },
     {
       name: "-webkit-text-fill-color",
       api_class: "CSSPropertyAPIColor",
+      api_methods: ["parseSingleValue"],
       custom_all: true,
       inherited: true,
     },
@@ -2027,6 +2115,7 @@
     {
       name: "-webkit-text-stroke-color",
       api_class: "CSSPropertyAPIColor",
+      api_methods: ["parseSingleValue"],
       custom_all: true,
       inherited: true,
       interpolable: true,
@@ -2034,6 +2123,7 @@
     {
       name: "-webkit-text-stroke-width",
       api_class: true,
+      api_methods: ["parseSingleValue"],
       converter: "convertTextStrokeWidth",
       inherited: true,
     },
@@ -2050,6 +2140,7 @@
     {
       name: "-webkit-transform-origin-z",
       api_class: true,
+      api_methods: ["parseSingleValue"],
       converter: "convertComputedLength<float>",
       interpolable: true,
     },
@@ -2088,6 +2179,7 @@
     {
       name: "will-change",
       api_class: true,
+      api_methods: ["parseSingleValue"],
       custom_all: true,
     },
     {
@@ -2097,6 +2189,7 @@
     {
       name: "word-spacing",
       api_class: "CSSPropertyAPILetterAndWordSpacing",
+      api_methods: ["parseSingleValue"],
       converter: "convertSpacing",
       inherited: true,
       initial: "initialLetterWordSpacing",
@@ -2111,6 +2204,7 @@
     {
       name: "z-index",
       api_class: true,
+      api_methods: ["parseSingleValue"],
       custom_all: true,
       interpolable: true,
       type_name: "int",
@@ -2136,11 +2230,13 @@
     {
       name: "max-inline-size",
       api_class: "CSSPropertyAPIWebkitMaxLogicalWidthOrHeight",
+      api_methods: ["parseSingleValue"],
       direction_aware: true,
     },
     {
       name: "max-block-size",
       api_class: "CSSPropertyAPIWebkitMaxLogicalWidthOrHeight",
+      api_methods: ["parseSingleValue"],
       direction_aware: true,
     },
 
@@ -2149,6 +2245,7 @@
     {
       name: "-webkit-border-end-color",
       api_class: "CSSPropertyAPIColor",
+      api_methods: ["parseSingleValue"],
       direction_aware: true,
     },
     {
@@ -2162,6 +2259,7 @@
     {
       name: "-webkit-border-start-color",
       api_class: "CSSPropertyAPIColor",
+      api_methods: ["parseSingleValue"],
       direction_aware: true,
     },
     {
@@ -2175,6 +2273,7 @@
     {
       name: "-webkit-border-before-color",
       api_class: "CSSPropertyAPIColor",
+      api_methods: ["parseSingleValue"],
       direction_aware: true,
     },
     {
@@ -2188,6 +2287,7 @@
     {
       name: "-webkit-border-after-color",
       api_class: "CSSPropertyAPIColor",
+      api_methods: ["parseSingleValue"],
       direction_aware: true,
     },
     {
@@ -2217,21 +2317,25 @@
     {
       name: "-webkit-padding-end",
       api_class: "CSSPropertyAPIWebkitPadding",
+      api_methods: ["parseSingleValue"],
       direction_aware: true,
     },
     {
       name: "-webkit-padding-start",
       api_class: "CSSPropertyAPIWebkitPadding",
+      api_methods: ["parseSingleValue"],
       direction_aware: true,
     },
     {
       name: "-webkit-padding-before",
       api_class: "CSSPropertyAPIWebkitPadding",
+      api_methods: ["parseSingleValue"],
       direction_aware: true,
     },
     {
       name: "-webkit-padding-after",
       api_class: "CSSPropertyAPIWebkitPadding",
+      api_methods: ["parseSingleValue"],
       direction_aware: true,
     },
     {
@@ -2253,11 +2357,13 @@
     {
       name: "-webkit-max-logical-width",
       api_class: "CSSPropertyAPIWebkitMaxLogicalWidthOrHeight",
+      api_methods: ["parseSingleValue"],
       direction_aware: true,
     },
     {
       name: "-webkit-max-logical-height",
       api_class: "CSSPropertyAPIWebkitMaxLogicalWidthOrHeight",
+      api_methods: ["parseSingleValue"],
       direction_aware: true,
     },
 
@@ -2271,11 +2377,13 @@
     {
       name: "page",
       api_class: true,
+      api_methods: ["parseSingleValue"],
       builder_skip: true,
     },
     {
       name: "-webkit-font-size-delta",
       api_class: true,
+      api_methods: ["parseSingleValue"],
       builder_skip: true,
     },
     {