Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(432)

Unified Diff: content/shell/browser/layout_test/layout_test_bluetooth_adapter_provider.h

Issue 2654403002: Implement WebBluetooth descriptor.writeValue() (Closed)
Patch Set: nit Created 3 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/shell/browser/layout_test/layout_test_bluetooth_adapter_provider.h
diff --git a/content/shell/browser/layout_test/layout_test_bluetooth_adapter_provider.h b/content/shell/browser/layout_test/layout_test_bluetooth_adapter_provider.h
index 9eb85ef8777154adaf5d461ea5e3e7a64c116c8d..efbec20e27024fc848d233431cbc4d224abc9a17 100644
--- a/content/shell/browser/layout_test/layout_test_bluetooth_adapter_provider.h
+++ b/content/shell/browser/layout_test/layout_test_bluetooth_adapter_provider.h
@@ -343,12 +343,14 @@ class LayoutTestBluetoothAdapterProvider {
// BluetoothRemoteGattCharacteristic::PROPERTY_READ
// - Descriptors (if |addDescriptors| input is true)
// - User Description (2901)
+ // Note: This descriptor can be written to and will always
ortuno 2017/01/31 19:50:09 Let's try to keep the formatting consistent: //
dougt 2017/01/31 20:59:16 Done.
+ // succeed.
// - Client Characteristic Configuration (2902)
// Note: This descriptor is blocklisted for writes.
// - bad2ddcf-60db-45cd-bef9-fd72b153cf7c
// A test descriptor that is blocklisted.
// - bad3ec61-3cc3-4954-9702-7977df514114
- // A test descriptor that is exclude read..
+ // A test descriptor that is exclude read.
static scoped_refptr<testing::NiceMock<device::MockBluetoothAdapter>>
GetDisconnectingHealthThermometer(bool add_descriptors);
@@ -400,6 +402,13 @@ class LayoutTestBluetoothAdapterProvider {
// succeeding callback, otherwise it saves a failing callback.
// This calback is run during CreateGattConnection. If
// |disconnect| is true disconnects the device.
+ // - user_descriptor
+ // - Operations read / write nearly identical to the read and
ortuno 2017/01/31 19:50:09 Not sure why this comment is here?
dougt 2017/01/31 20:59:16 I am documenting that under the Measurement Interv
+ // write methods of the characteristic.
+ // - Read: If |succeeds| is true, saves a succeeding callback,
+ // otherwise it saves a failing callback.
+ // - Write: If |succeeds| is true, saves a succeeding callback
+ // otherwise it saves a failing callback.
// - CreateGattConnection: Runs success callback with a new GATT
// connection and runs any pending GATT operation callbacks.
static scoped_refptr<testing::NiceMock<device::MockBluetoothAdapter>>

Powered by Google App Engine
This is Rietveld 408576698