Implement WebBluetooth descriptor.writeValue()

content/shell/browser/layout_test/layout_test_bluetooth_adapter_provider.h

 // Copyright 2015 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef CONTENT_SHELL_BROWSER_LAYOUT_TEST_LAYOUT_TEST_BLUETOOTH_ADAPTER_PROVIDER_H_
 #define CONTENT_SHELL_BROWSER_LAYOUT_TEST_LAYOUT_TEST_BLUETOOTH_ADAPTER_PROVIDER_H_
 
 #include <stdint.h>
 
 #include "base/callback.h"
@@ skipping 325 matching lines @@
   //       - Health Thermometer:
   //         - Measurement Interval (0x2a21):
   //           - Read: Calls GattCharacteristicValueChanged and success
   //               callback with [1].
   //           - Write: Calls success callback.
   //           - StartNotifySession: Run success callback.
   //           - GetProperties: Returns
   //               BluetoothRemoteGattCharacteristic::PROPERTY_READ
   //           - Descriptors (if |addDescriptors| input is true)
   //             - User Description (2901)
+  //                 Note: This descriptor can be written to and will always

[ortuno, 2017/01/31 19:50:09]

Let's try to keep the formatting consistent:

//        - Mock Functions:
//           - Read: Calls success callback with
"gatt.characteristic_user_description".
//           - Write: Calls success callback.

[dougt, 2017/01/31 20:59:16]

Done.

+  //                 succeed.
   //             - Client Characteristic Configuration (2902)
   //                 Note: This descriptor is blocklisted for writes.
   //             - bad2ddcf-60db-45cd-bef9-fd72b153cf7c
   //                 A test descriptor that is blocklisted.
   //             - bad3ec61-3cc3-4954-9702-7977df514114
-  //                 A test descriptor that is exclude read..
+  //                 A test descriptor that is exclude read.
 
   static scoped_refptr<testing::NiceMock<device::MockBluetoothAdapter>>
   GetDisconnectingHealthThermometer(bool add_descriptors);
 
   // |ServicesDiscoveredAfterReconnectionAdapter|(disconnect)
   // Inherits from |HeartRateAdapter|
   // Internal Structure:
   //   - Heart Rate Device
   //      - UUIDs:
   //         - Generic Access UUID (0x1800)
@@ skipping 31 matching lines @@
   //                 is run during CreateGattConnection. If |disconnect| is true
   //                 disconnects the device.
   //               - Write: If |succeeds| is true, saves a succeeding callback,
   //                 otherwise it saves a failing callback. This callback is run
   //                 during CreateGattConnection. If |disconnect| is true
   //                 disconnects the device.
   //               - StartNotifySession: If |succeeds| is true, saves a
   //                 succeeding callback, otherwise it saves a failing callback.
   //                 This calback is run during CreateGattConnection. If
   //                 |disconnect| is true disconnects the device.
+  //               - user_descriptor
+  //                 - Operations read / write nearly identical to the read and

[ortuno, 2017/01/31 19:50:09]

Not sure why this comment is here?

[dougt, 2017/01/31 20:59:16]

I am documenting that under the Measurement Interval characteristic, there is a
user_descriptor descriptor.

+  //                   write methods of the characteristic.
+  //                 - Read: If |succeeds| is true, saves a succeeding callback,
+  //                   otherwise it saves a failing callback.
+  //                 - Write: If |succeeds| is true, saves a succeeding callback
+  //                   otherwise it saves a failing callback.
   //         - CreateGattConnection: Runs success callback with a new GATT
   //           connection and runs any pending GATT operation callbacks.
   static scoped_refptr<testing::NiceMock<device::MockBluetoothAdapter>>
   GetGATTOperationFinishesAfterReconnectionAdapter(bool disconnect,
                                                    bool succeeds);
 
   // |StopNotifySessionFinishesAfterReconnection|(disconnect)
   // Inherits from |EmptyAdapter|
   // Internal Structure:
   //   - Health Thermometer Device
@@ skipping 442 matching lines @@
 
   // Function to turn an integer into an MAC address of the form
   // XX:XX:XX:XX:XX:XX. For example makeMACAddress(0xdeadbeef)
   // returns "00:00:DE:AD:BE:EF".
   static std::string makeMACAddress(uint64_t addr);
 };
 
 }  // namespace content
 
 #endif  // CONTENT_SHELL_BROWSER_LAYOUT_TEST_LAYOUT_TEST_BLUETOOTH_ADAPTER_PROVIDER_H_