third_party/WebKit/LayoutTests/bluetooth/descriptor/writeValue/value-too-long.html - Issue 2654403002: Implement WebBluetooth descriptor.writeValue()

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/LayoutTests/bluetooth/descriptor/writeValue/value-too-long.html

Issue 2654403002: Implement WebBluetooth descriptor.writeValue() (Closed)

Patch Set: Inital Created 3 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« third_party/WebKit/LayoutTests/bluetooth/descriptor/readValue/gen-io-op-reconnect-during-error.html ('K') | « third_party/WebKit/LayoutTests/bluetooth/descriptor/writeValue/gen-service-is-removed.html ('k') | third_party/WebKit/LayoutTests/bluetooth/descriptor/writeValue/write-succeeds.html » ('j') | third_party/WebKit/LayoutTests/bluetooth/descriptor/writeValue/write-succeeds.html » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/LayoutTests/bluetooth/descriptor/writeValue/value-too-long.html

diff --git a/third_party/WebKit/LayoutTests/bluetooth/descriptor/writeValue/value-too-long.html b/third_party/WebKit/LayoutTests/bluetooth/descriptor/writeValue/value-too-long.html

new file mode 100644

index 0000000000000000000000000000000000000000..e04088c317b8bdee5c4ecffa96a5d981369665c9

--- /dev/null

+++ b/third_party/WebKit/LayoutTests/bluetooth/descriptor/writeValue/value-too-long.html

@@ -0,0 +1,23 @@

+<!DOCTYPE html>

+<script src="../../../resources/testharness.js"></script>

+<script src="../../../resources/testharnessreport.js"></script>

+<script src="../../../resources/bluetooth/bluetooth-helpers.js"></script>

+<script>

+'use strict';

+promise_test(() => {

+ return setBluetoothFakeAdapter('DisconnectingHealthThermometerAdapter')

+ .then(() => requestDeviceWithKeyDown({

+ filters: [{services: ['health_thermometer']}]}))

+ .then(device => device.gatt.connect())

+ .then(gattServer => gattServer.getPrimaryService('health_thermometer'))

+ .then(service => service.getCharacteristic('measurement_interval'))

+ .then(characteristic => characteristic.getDescriptor(user_description.name))

+ .then(descriptor => {

+ return assert_promise_rejects_with_message(

+ descriptor.writeValue(new Uint8Array(513 /* length */)),

+ new DOMException(

+ 'Value can\'t exceed 512 bytes.', 'InvalidModificationError'),

+ 'Value passed was too long.');

+ })

+ }, 'A regular write request to a writable descriptor should succeed.');

ortuno 2017/01/28 00:22:51 nit: Fix description and formatting.

dougt 2017/01/31 00:31:25 Done.

+</script>