third_party/WebKit/LayoutTests/bluetooth/descriptor/writeValue/value-too-long.html - Issue 2654403002: Implement WebBluetooth descriptor.writeValue()

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: third_party/WebKit/LayoutTests/bluetooth/descriptor/writeValue/value-too-long.html

Issue 2654403002: Implement WebBluetooth descriptor.writeValue() (Closed)

Patch Set: Inital Created 3 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

OLD	NEW
(Empty)
	1 <!DOCTYPE html>

	2 <script src="../../../resources/testharness.js"></script>

	3 <script src="../../../resources/testharnessreport.js"></script>

	4 <script src="../../../resources/bluetooth/bluetooth-helpers.js"></script>

	5 <script>

	6 'use strict';

	7 promise_test(() => {

	8 return setBluetoothFakeAdapter('DisconnectingHealthThermometerAdapter')

	9 .then(() => requestDeviceWithKeyDown({

	10 filters: [{services: ['health_thermometer']}]}))

	11 .then(device => device.gatt.connect())

	12 .then(gattServer => gattServer.getPrimaryService('health_thermometer'))

	13 .then(service => service.getCharacteristic('measurement_interval'))

	14 .then(characteristic => characteristic.getDescriptor(user_description.name))

	15 .then(descriptor => {

	16 return assert_promise_rejects_with_message(

	17 descriptor.writeValue(new Uint8Array(513 /* length */)),

	18 new DOMException(

	19 'Value can\'t exceed 512 bytes.', 'InvalidModificationError'),

	20 'Value passed was too long.');

	21 })

	22 }, 'A regular write request to a writable descriptor should succeed.');
	ortuno 2017/01/28 00:22:51 nit: Fix description and formatting. nit: Fix description and formatting. dougt 2017/01/31 00:31:25 Done. Show quoted text On 2017/01/28 00:22:51, ortuno wrote: > nit: Fix description and formatting. Done.
	23 </script>

OLD	NEW