Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(479)

Issue 2654383003: Update fast/table/backgr_* test expectations for Win and Mac (Closed)

Created:
3 years, 10 months ago by kjellander_chromium
Modified:
3 years, 10 months ago
Reviewers:
qyearsley
CC:
chromium-reviews, blink-reviews
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Update fast/table/backgr_* test expectations for Win and Mac BUG=685851 TBR=qyearsley@chromium.org NOTRY=True Review-Url: https://codereview.chromium.org/2654383003 Cr-Commit-Position: refs/heads/master@{#446661} Committed: https://chromium.googlesource.com/chromium/src/+/f28899ff8e6bf44ec46f1aba4a27cbf2294ff7cf

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+43 lines, -0 lines) Patch
M third_party/WebKit/LayoutTests/TestExpectations View 1 chunk +43 lines, -0 lines 0 comments Download

Messages

Total messages: 7 (3 generated)
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2654383003/1
3 years, 10 months ago (2017-01-27 13:49:02 UTC) #2
commit-bot: I haz the power
Committed patchset #1 (id:1) as https://chromium.googlesource.com/chromium/src/+/f28899ff8e6bf44ec46f1aba4a27cbf2294ff7cf
3 years, 10 months ago (2017-01-27 13:55:15 UTC) #5
pdr.
On 2017/01/27 at 13:55:15, commit-bot wrote: > Committed patchset #1 (id:1) as https://chromium.googlesource.com/chromium/src/+/f28899ff8e6bf44ec46f1aba4a27cbf2294ff7cf When uploading ...
3 years, 10 months ago (2017-01-27 21:10:18 UTC) #6
kjellander_chromium
3 years, 10 months ago (2017-01-27 21:18:55 UTC) #7
Message was sent while issue was closed.
On 2017/01/27 21:10:18, pdr. wrote:
> On 2017/01/27 at 13:55:15, commit-bot wrote:
> > Committed patchset #1 (id:1) as
>
https://chromium.googlesource.com/chromium/src/+/f28899ff8e6bf44ec46f1aba4a27...
> 
> When uploading an unrelated change, I'm now getting:
> ** Presubmit ERRORS **
> 
> LayoutTests/TestExpectations:829 Entries for
> fast/table/backgr_layers-show-collapsed-border.html on lines
> LayoutTests/TestExpectations:771 and LayoutTests/TestExpectations:829 match
> overlapping sets of configurations.
> fast/table/backgr_layers-show-collapsed-border.html
> LayoutTests/TestExpectations:841 More specific entry for
> fast/table/backgr_simple-table-cell.html on line
> LayoutTests/TestExpectations:841 overrides line
> LayoutTests/TestExpectations:774. fast/table/backgr_simple-table-cell.html
> LayoutTests/TestExpectations:851 Entries for
> fast/table/backgr_simple-table-row.html on lines
> LayoutTests/TestExpectations:776 and LayoutTests/TestExpectations:851 match
> overlapping sets of configurations. fast/table/backgr_simple-table-row.html
> LayoutTests/TestExpectations:853 Entries for
> fast/table/backgr_simple-table-row-group-collapsed-border.html on lines
> LayoutTests/TestExpectations:775 and LayoutTests/TestExpectations:853 match
> overlapping sets of configurations.
> fast/table/backgr_simple-table-row-group-collapsed-border.html
> LayoutTests/TestExpectations:860 Entries for
fast/table/backgr_layers-show.html
> on lines LayoutTests/TestExpectations:772 and LayoutTests/TestExpectations:860
> match overlapping sets of configurations. fast/table/backgr_layers-show.html
> LayoutTests/TestExpectations:866 Entries for
> fast/table/backgr_position-table-cell.html on lines
> LayoutTests/TestExpectations:773 and LayoutTests/TestExpectations:866 match
> overlapping sets of configurations. fast/table/backgr_position-table-cell.html
> 
> Lint failed.

Can you sync and try again? I don't see any duplicated entries in HEAD.

Powered by Google App Engine
This is Rietveld 408576698