Enable use-after-scope check on Chrome OS.

Enable use-after-scope check on Chrome OS.

Now that Chrome OS uses a recent enough Clang toolchain,
it's possible to enable the check there too.

BUG=683445, 649897
Review-Url: https://codereview.chromium.org/2654383002
Cr-Commit-Position: refs/heads/master@{#446503}
Committed: https://chromium.googlesource.com/chromium/src/+/539f64c0e54adc91ae1276948771a3538cf4261b

[krasin1, 2017-01-26 19:37:26]

krasin@chromium.org changed reviewers:
+ llozano@chromium.org, thakis@chromium.org

[krasin1, 2017-01-26 19:37:32]

The CQ bit was checked by krasin@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-01-26 19:38:11]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Nico, 2017-01-26 19:39:27]

lgtm if llozano likes it

[krasin1, 2017-01-26 19:42:42]

The CQ bit was unchecked by krasin@chromium.org

[llozano, 2017-01-26 19:44:56]

lgtm

I like it :)

[krasin1, 2017-01-26 19:51:34]

On 2017/01/26 19:44:56, llozano wrote:
> lgtm
> 
> I like it :)

Great. I will wait until linux_chromium_chromeos_asan_rel_ng succeeds and then
submit the CL.

Btw, any reason the bot (linux_chromium_chromeos_asan_rel_ng) is not a part of
the CQ?

[krasin1, 2017-01-26 20:29:58]

The CQ bit was checked by krasin@chromium.org

[commit-bot: I haz the power, 2017-01-26 20:30:28]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[krasin1, 2017-01-26 20:31:08]

The CQ bit was unchecked by krasin@chromium.org

[llozano, 2017-01-26 20:45:01]

Description was changed from

==========
Enable use-after-scope check on Chrome OS.

Now that Chrome OS uses a recent enough Clang toolchain,
it's possible to enable the check there too.

BUG=683445,649897
==========

to

==========
Enable use-after-scope check on Chrome OS.

Now that Chrome OS uses a recent enough Clang toolchain,
it's possible to enable the check there too.

BUG=683445,649897
==========

[llozano, 2017-01-26 20:45:56]

On 2017/01/26 20:30:28, commit-bot: I haz the power wrote:
> CQ is trying da patch. Follow status at
>  
>
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

about #8, I dont know the anwer to that. 

@stevenjb, do you know ? who can we ask about this to try to get it changed?

[stevenjb, 2017-01-26 20:57:04]

On 2017/01/26 19:51:34, krasin1 wrote:
> On 2017/01/26 19:44:56, llozano wrote:
> > lgtm
> > 
> > I like it :)
> 
> Great. I will wait until linux_chromium_chromeos_asan_rel_ng succeeds and then
> submit the CL.
> 
> Btw, any reason the bot (linux_chromium_chromeos_asan_rel_ng) is not a part of
> the CQ?

You would have to ask a cros infra person, but I believe that the asan builders
are expensive/slow. There is a practical limit to how many builders we can run
automatically in the cq.

[krasin1, 2017-01-26 23:36:53]

The CQ bit was checked by krasin@chromium.org

[commit-bot: I haz the power, 2017-01-26 23:37:28]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-01-27 00:42:06]

CQ is committing da patch.

Bot data: {"patchset_id": 1, "attempt_start_ts": 1485473813935730, "parent_rev":
"48068f44c839c61edbe33b0427b524e408b403b2", "commit_rev":
"539f64c0e54adc91ae1276948771a3538cf4261b"}

[commit-bot: I haz the power, 2017-01-27 00:42:43]

Description was changed from

==========
Enable use-after-scope check on Chrome OS.

Now that Chrome OS uses a recent enough Clang toolchain,
it's possible to enable the check there too.

BUG=683445,649897
==========

to

==========
Enable use-after-scope check on Chrome OS.

Now that Chrome OS uses a recent enough Clang toolchain,
it's possible to enable the check there too.

BUG=683445,649897

Review-Url: https://codereview.chromium.org/2654383002
Cr-Commit-Position: refs/heads/master@{#446503}
Committed:
https://chromium.googlesource.com/chromium/src/+/539f64c0e54adc91ae1276948771...
==========

[commit-bot: I haz the power, 2017-01-27 00:42:44]

Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/539f64c0e54adc91ae1276948771...